All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sagar Dharia <sdharia-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	bp-l3A5Bk7waGM@public.gmane.org,
	poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org,
	treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	gong.chen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	daniel-/w4YWyX8dFk@public.gmane.org,
	jkosina-AlSwsSmVLrQ@public.gmane.org,
	sharon.dvir1-MQgwKvJRKlGYZoqfULhbRA@public.gmane.org,
	joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org,
	michael.opdenacker-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kheitke-hxvC4TZJLZFWk0Htik3J/w@public.gmane.org,
	mlocke-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	sheetal.tigadoli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus
Date: Thu, 28 Apr 2016 16:59:02 +0200	[thread overview]
Message-ID: <5047442.UXEhPc2Isi@wuerfel> (raw)
In-Reply-To: <20160428143801.GO3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Thursday 28 April 2016 15:38:01 Mark Brown wrote:
> On Thu, Apr 28, 2016 at 02:33:41PM +0200, Arnd Bergmann wrote:
> > On Thursday 28 April 2016 12:53:37 Mark Brown wrote:
> > I don't foresee mobile phones with ACPI using this subsystem, but even
> > if we got them, it would be a horrible idea to use hardcoded board
> > specific tables in a platform file, and we should insist that whatever
> > firmware is present has a way to describe the slimbus devices.
> 
> Right, in this particular case I don't think it makes a huge difference
> but what you were talking about was "ancient pre-DT times" rather than
> something specific to this particular case.  That's definitely a thing
> that people keep thinking and it's good to push back on it since we do
> have non-DT cases to worry about (some architectures, other firmwares,
> things like PCI cards with other components on them and so on).

Ok, I see what you mean. It turns out I made the exact same
comment on the first review five years ago (phrased more
nicely back then):

http://thread.gmane.org/gmane.linux.documentation/3192/focus=3193

My comment this time was for the particular driver, but I'd
still also maintain that a new subsystem in general should not
start out by addressing the needs of traditional board files.
I don't think we have merge new platform support on any
architecture that would need this in the past years and
stuff like spi_board_info and i2c_board_info is only really
used on really old machines (but not going away any time soon
either).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@kernel.org>
Cc: Sagar Dharia <sdharia@codeaurora.org>,
	gregkh@linuxfoundation.org, bp@suse.de, poeschel@lemonage.de,
	treding@nvidia.com, gong.chen@linux.intel.com,
	andreas.noever@gmail.com, alan@linux.intel.com,
	mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz,
	sharon.dvir1@mail.huji.ac.il, joe@perches.com,
	davem@davemloft.net, james.hogan@imgtec.com,
	michael.opdenacker@free-electrons.com,
	daniel.thompson@linaro.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kheitke@audience.com, mlocke@codeaurora.org,
	agross@codeaurora.org, sheetal.tigadoli@gmail.com,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus
Date: Thu, 28 Apr 2016 16:59:02 +0200	[thread overview]
Message-ID: <5047442.UXEhPc2Isi@wuerfel> (raw)
In-Reply-To: <20160428143801.GO3217@sirena.org.uk>

On Thursday 28 April 2016 15:38:01 Mark Brown wrote:
> On Thu, Apr 28, 2016 at 02:33:41PM +0200, Arnd Bergmann wrote:
> > On Thursday 28 April 2016 12:53:37 Mark Brown wrote:
> > I don't foresee mobile phones with ACPI using this subsystem, but even
> > if we got them, it would be a horrible idea to use hardcoded board
> > specific tables in a platform file, and we should insist that whatever
> > firmware is present has a way to describe the slimbus devices.
> 
> Right, in this particular case I don't think it makes a huge difference
> but what you were talking about was "ancient pre-DT times" rather than
> something specific to this particular case.  That's definitely a thing
> that people keep thinking and it's good to push back on it since we do
> have non-DT cases to worry about (some architectures, other firmwares,
> things like PCI cards with other components on them and so on).

Ok, I see what you mean. It turns out I made the exact same
comment on the first review five years ago (phrased more
nicely back then):

http://thread.gmane.org/gmane.linux.documentation/3192/focus=3193

My comment this time was for the particular driver, but I'd
still also maintain that a new subsystem in general should not
start out by addressing the needs of traditional board files.
I don't think we have merge new platform support on any
architecture that would need this in the past years and
stuff like spi_board_info and i2c_board_info is only really
used on really old machines (but not going away any time soon
either).

	Arnd

  parent reply	other threads:[~2016-04-28 14:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 23:58 [PATCH V5 0/6] Introduce framework for SLIMbus device drivers Sagar Dharia
2016-04-27 23:58 ` [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Sagar Dharia
2016-04-28 10:00   ` Arnd Bergmann
2016-04-28 11:53     ` Mark Brown
2016-04-28 12:33       ` Arnd Bergmann
2016-04-28 14:38         ` Mark Brown
     [not found]           ` <20160428143801.GO3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-28 14:59             ` Arnd Bergmann [this message]
2016-04-28 14:59               ` Arnd Bergmann
2016-04-28 16:39               ` Mark Brown
2016-04-28 16:49                 ` Arnd Bergmann
2016-04-29 11:17                   ` Mark Brown
2016-04-29 11:17                     ` Mark Brown
2016-05-06 17:35                     ` Sagar Dharia
2016-06-03  9:14   ` Masami Hiramatsu
2016-04-27 23:58 ` [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Sagar Dharia
2016-04-28  9:54   ` Arnd Bergmann
2016-04-28 11:11   ` Mark Rutland
2016-05-03 16:11   ` Rob Herring
2016-05-03 19:26     ` Arnd Bergmann
2016-04-27 23:58 ` [PATCH V5 3/6] slimbus: Add messaging APIs to slimbus framework Sagar Dharia
2016-04-28  9:52   ` Arnd Bergmann
2016-04-27 23:58 ` [PATCH V5 4/6] slim: qcom: Add Qualcomm Slimbus controller driver Sagar Dharia
     [not found]   ` <1461801489-16254-5-git-send-email-sdharia-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-28 11:28     ` Mark Rutland
2016-04-28 11:28       ` Mark Rutland
2016-05-06 17:28       ` Sagar Dharia
2016-04-27 23:58 ` [PATCH V5 5/6] slimbus: Add support for 'clock-pause' feature Sagar Dharia
2016-04-27 23:58 ` [PATCH V5 6/6] slim: qcom: Add runtime-pm support using clock-pause feature Sagar Dharia
2016-06-03  9:14 ` [PATCH V5 0/6] Introduce framework for SLIMbus device drivers Masami Hiramatsu
2016-06-27  1:30   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5047442.UXEhPc2Isi@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=bp-l3A5Bk7waGM@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=gong.chen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org \
    --cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=kheitke-hxvC4TZJLZFWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=michael.opdenacker-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=mlocke-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sdharia-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=sharon.dvir1-MQgwKvJRKlGYZoqfULhbRA@public.gmane.org \
    --cc=sheetal.tigadoli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.