From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v5 2/4] pwm_backlight: use power sequences Date: Wed, 05 Sep 2012 11:25:27 -0600 Message-ID: <50478B07.4080708@wwwdotorg.org> References: <1346412846-17102-1-git-send-email-acourbot@nvidia.com> <1346412846-17102-3-git-send-email-acourbot@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1346412846-17102-3-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot Cc: Stephen Warren , Thierry Reding , Simon Glass , Grant Likely , Rob Herring , Mark Brown , Anton Vorontsov , David Woodhouse , Arnd Bergmann , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/31/2012 05:34 AM, Alexandre Courbot wrote: > Make use of the power sequences specified in the device tree or platform > data to control how the backlight is powered on and off. > +++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt > Optional properties: > - - pwm-names: a list of names for the PWM devices specified in the > - "pwms" property (see PWM binding[0]) > + - pwm-names: name for the PWM device specified in the "pwms" property (see PWM > + binding[0]). Necessary if power sequences are used So this implies that power sequence are completely optional in the pwm binding... > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > config BACKLIGHT_PWM > tristate "Generic PWM based Backlight Driver" > depends on PWM > + select POWER_SEQ ... but that implies they're basically mandatory. Briefly looking at the code, power sequences don't appear to be optional, at least for the DT case, so perhaps you just need to update the documentation to make "pwm-names" non-optional? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759084Ab2IERZe (ORCPT ); Wed, 5 Sep 2012 13:25:34 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:53232 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193Ab2IERZc (ORCPT ); Wed, 5 Sep 2012 13:25:32 -0400 Message-ID: <50478B07.4080708@wwwdotorg.org> Date: Wed, 05 Sep 2012 11:25:27 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Alexandre Courbot CC: Stephen Warren , Thierry Reding , Simon Glass , Grant Likely , Rob Herring , Mark Brown , Anton Vorontsov , David Woodhouse , Arnd Bergmann , linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v5 2/4] pwm_backlight: use power sequences References: <1346412846-17102-1-git-send-email-acourbot@nvidia.com> <1346412846-17102-3-git-send-email-acourbot@nvidia.com> In-Reply-To: <1346412846-17102-3-git-send-email-acourbot@nvidia.com> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2012 05:34 AM, Alexandre Courbot wrote: > Make use of the power sequences specified in the device tree or platform > data to control how the backlight is powered on and off. > +++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt > Optional properties: > - - pwm-names: a list of names for the PWM devices specified in the > - "pwms" property (see PWM binding[0]) > + - pwm-names: name for the PWM device specified in the "pwms" property (see PWM > + binding[0]). Necessary if power sequences are used So this implies that power sequence are completely optional in the pwm binding... > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > config BACKLIGHT_PWM > tristate "Generic PWM based Backlight Driver" > depends on PWM > + select POWER_SEQ ... but that implies they're basically mandatory. Briefly looking at the code, power sequences don't appear to be optional, at least for the DT case, so perhaps you just need to update the documentation to make "pwm-names" non-optional? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 05 Sep 2012 17:25:27 +0000 Subject: Re: [PATCH v5 2/4] pwm_backlight: use power sequences Message-Id: <50478B07.4080708@wwwdotorg.org> List-Id: References: <1346412846-17102-1-git-send-email-acourbot@nvidia.com> <1346412846-17102-3-git-send-email-acourbot@nvidia.com> In-Reply-To: <1346412846-17102-3-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexandre Courbot Cc: Stephen Warren , Thierry Reding , Simon Glass , Grant Likely , Rob Herring , Mark Brown , Anton Vorontsov , David Woodhouse , Arnd Bergmann , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 08/31/2012 05:34 AM, Alexandre Courbot wrote: > Make use of the power sequences specified in the device tree or platform > data to control how the backlight is powered on and off. > +++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt > Optional properties: > - - pwm-names: a list of names for the PWM devices specified in the > - "pwms" property (see PWM binding[0]) > + - pwm-names: name for the PWM device specified in the "pwms" property (see PWM > + binding[0]). Necessary if power sequences are used So this implies that power sequence are completely optional in the pwm binding... > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > config BACKLIGHT_PWM > tristate "Generic PWM based Backlight Driver" > depends on PWM > + select POWER_SEQ ... but that implies they're basically mandatory. Briefly looking at the code, power sequences don't appear to be optional, at least for the DT case, so perhaps you just need to update the documentation to make "pwm-names" non-optional?