From: Naresh Kumar Inna <naresh@chelsio.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "JBottomley@parallels.com" <JBottomley@parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Dimitrios Michailidis <dm@chelsio.com>,
Casey Leedom <leedom@chelsio.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Chethan Seshadri <chethan@chelsio.com>
Subject: Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).
Date: Wed, 5 Sep 2012 23:14:30 +0530 [thread overview]
Message-ID: <50478F7E.1020606@chelsio.com> (raw)
In-Reply-To: <20120905093305.2418eac8@nehalam.linuxnetplumber.net>
On 9/5/2012 10:03 PM, Stephen Hemminger wrote:
> On Wed, 5 Sep 2012 18:03:59 +0530
> Naresh Kumar Inna <naresh@chelsio.com> wrote:
>
>> +
>> +#define CSIO_ASSERT(cond) \
>> +do { \
>> + if (unlikely(!((cond)))) \
>> + BUG(); \
>> +} while (0)
>> +
>
> Why is this not just BUG_ON(!(cond)) ?
>
I will replace the 2 lines in the macro with BUG_ON() as you have
suggested. Thanks.
next prev parent reply other threads:[~2012-09-05 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 12:33 [V2 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1) Naresh Kumar Inna
2012-09-05 16:23 ` Stephen Hemminger
2012-09-05 17:18 ` Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2) Naresh Kumar Inna
2012-09-05 16:29 ` Stephen Hemminger
2012-09-05 17:43 ` Naresh Kumar Inna
2012-09-05 22:59 ` Stephen Hemminger
2012-09-05 12:33 ` [V2 PATCH 3/9] csiostor: Chelsio FCoE offload driver submission (sources part 3) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 4/9] csiostor: Chelsio FCoE offload driver submission (sources part 4) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 5/9] csiostor: Chelsio FCoE offload driver submission (sources part 5) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1) Naresh Kumar Inna
2012-09-05 16:31 ` Stephen Hemminger
2012-09-05 17:26 ` Naresh Kumar Inna
2012-09-05 23:07 ` Ben Hutchings
2012-09-05 16:33 ` Stephen Hemminger
2012-09-05 17:44 ` Naresh Kumar Inna [this message]
2012-09-05 12:34 ` [V2 PATCH 7/9] csiostor: Chelsio FCoE offload driver submission (headers part 2) Naresh Kumar Inna
2012-09-05 12:34 ` [V2 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates) Naresh Kumar Inna
2012-09-05 12:34 ` [V2 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes) Naresh Kumar Inna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50478F7E.1020606@chelsio.com \
--to=naresh@chelsio.com \
--cc=JBottomley@parallels.com \
--cc=chethan@chelsio.com \
--cc=dm@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.