All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] common: Accept pause character in the dialing number
Date: Wed, 05 Sep 2012 14:25:36 -0500	[thread overview]
Message-ID: <5047A730.4060008@gmail.com> (raw)
In-Reply-To: <1346865579-24794-3-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Hi Philippe,

On 09/05/2012 12:19 PM, Philippe Nunes wrote:
> ---
>   src/common.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/common.c b/src/common.c
> index 94d70dd..de1ad26 100644
> --- a/src/common.c
> +++ b/src/common.c
> @@ -257,7 +257,7 @@ gboolean valid_number_format(const char *number, int length)
>   		if (number[i]>= '0'&&  number[i]<= '9')
>   			continue;
>
> -		if (number[i] == '*' || number[i] == '#')
> +		if (number[i] == '*' || number[i] == '#' || number[i] == 'p')
>   			continue;
>
>   		return FALSE;

You can't really mess directly with this function since it is used in 
places where pause characters are not appropriate, e.g. SMS, Call 
Forwarding, Deflection, numbers stored on the SIM, etc.

Also, we can't simply accept the pause character in the voicecall atom 
today.  That would require us to implement proper dial string support as 
sending pause characters directly is not really supported on many modems.

Regards,
-Denis

  reply	other threads:[~2012-09-05 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 17:19 [PATCH 0/4] DTMF in dialing number Philippe Nunes
2012-09-05 17:19 ` [PATCH 1/4] stk: convert to phone number format Philippe Nunes
2012-09-05 17:19 ` [PATCH 2/4] common: Accept pause character in the dialing number Philippe Nunes
2012-09-05 19:25   ` Denis Kenzior [this message]
2012-09-05 17:19 ` [PATCH 3/4] voicecall: Accept long phone number format for STK Philippe Nunes
2012-09-05 19:26   ` Denis Kenzior
2012-09-05 17:19 ` [PATCH 4/4] stk: AID shall not be displayed in case of self explanatory icon Philippe Nunes
2012-09-05 19:29   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5047A730.4060008@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.