From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F422BC48BE5 for ; Thu, 17 Jun 2021 09:20:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5ADE613D5 for ; Thu, 17 Jun 2021 09:20:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5ADE613D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D1C86E8CE; Thu, 17 Jun 2021 09:20:22 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A5DD6E8CE for ; Thu, 17 Jun 2021 09:20:20 +0000 (UTC) IronPort-SDR: E7CaFqB/PTJ1Qo3bs4ovPztNQU09pI5twizWYxI90ljBLD4VkFfq1p+QyQali90cfWJ+aiaV8y uzEINQo0OieA== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="291967225" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="291967225" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 02:20:19 -0700 IronPort-SDR: uYNUCwTDHEapetovfPYtlMvy6NdZvl+It+wgsKnZQw1Ij+W6RUUYahom0LZ5yMkFiOYmuguo4X Rp8bHA7o55Tw== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="621991727" Received: from bmoran1x-mobl3.ger.corp.intel.com (HELO [10.213.219.91]) ([10.213.219.91]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 02:20:17 -0700 Subject: Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc From: Tvrtko Ursulin To: Chris Wilson , dri-devel@lists.freedesktop.org References: <20201118163601.958254-1-tvrtko.ursulin@linux.intel.com> <160571907017.19853.2138891452982731448@build.alporthouse.com> <160579393163.30679.15261134775534336025@build.alporthouse.com> Organization: Intel Corporation UK Plc Message-ID: <5047dfbb-6097-3af7-b5ac-7103085daae0@linux.intel.com> Date: Thu, 17 Jun 2021 10:20:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel Landwerlin , Tvrtko Ursulin , David Airlie , Eric Engestrom , "Kempczynski, Zbigniew" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" + a bunch of recent committers to libdrm Guys, anyone okay to push this patch? I can resend if required. Regards, Tvrtko On 19/11/2020 13:58, Tvrtko Ursulin wrote: > > On 19/11/2020 13:52, Chris Wilson wrote: >> Quoting Tvrtko Ursulin (2020-11-19 13:42:07) >>> >>> On 18/11/2020 17:04, Chris Wilson wrote: >>>> Quoting Tvrtko Ursulin (2020-11-18 16:36:01) >>>>> From: Tvrtko Ursulin >>>>> >>>>> There is this long standing nit of igt/tools/intel_error_decode >>>>> asserting >>>>> when you feed it an error state from a GPU the local libdrm does >>>>> not know >>>>> of. >>>>> >>>>> To fix this I need a tweak in drm_intel_decode_context_alloc to >>>>> make it >>>>> not assert but just return NULL (which seems an already possible >>>>> return >>>>> value). >>>>> >>>>> Signed-off-by: Tvrtko Ursulin >>>> >>>> Good riddance, >>>> Reviewed-by: Chris Wilson >>> >>> Thanks, now how can push to drm and is there some testing to be >>> triggered before, or after? >> >> cd intel; for i in tests/gen*.sh; do $i; done >> >> But clearly I haven't built libdrm since automake was dropped. > > Thanks, all good: > > $ for t in ../../intel/tests/gen*.sh; do bash -x $t; done > ++ echo ../../intel/tests/gen4-3d.batch.sh > ++ sed 's|\.sh$||' > + TEST_FILENAME=../../intel/tests/gen4-3d.batch > + ./test_decode ../../intel/tests/gen4-3d.batch > + ret=0 > + test 0 = 1 > + exit 0 > ++ echo ../../intel/tests/gen5-3d.batch.sh > ++ sed 's|\.sh$||' > + TEST_FILENAME=../../intel/tests/gen5-3d.batch > + ./test_decode ../../intel/tests/gen5-3d.batch > + ret=0 > + test 0 = 1 > + exit 0 > ++ echo ../../intel/tests/gen6-3d.batch.sh > ++ sed 's|\.sh$||' > + TEST_FILENAME=../../intel/tests/gen6-3d.batch > + ./test_decode ../../intel/tests/gen6-3d.batch > + ret=0 > + test 0 = 1 > + exit 0 > ++ echo ../../intel/tests/gen7-2d-copy.batch.sh > ++ sed 's|\.sh$||' > + TEST_FILENAME=../../intel/tests/gen7-2d-copy.batch > + ./test_decode ../../intel/tests/gen7-2d-copy.batch > + ret=0 > + test 0 = 1 > + exit 0 > ++ echo ../../intel/tests/gen7-3d.batch.sh > ++ sed 's|\.sh$||' > + TEST_FILENAME=../../intel/tests/gen7-3d.batch > + ./test_decode ../../intel/tests/gen7-3d.batch > + ret=0 > + test 0 = 1 > + exit 0 > > Regards, > > Tvrtko > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel