From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Thu, 06 Sep 2012 11:44:32 +0300 Message-ID: <50486270.9020504@redhat.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , =?UTF-8?B?QW5kcmVhcyBGw6RyYmU=?= =?UTF-8?B?cg==?= , kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , qemu-ppc To: Blue Swirl Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab2IFIoq (ORCPT ); Thu, 6 Sep 2012 04:44:46 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 09/05/2012 10:04 PM, Blue Swirl wrote: > > Reinventing a disassembler for ever growing x86 assembly is > no fun. We can try linking to a disassembler library. I use udis86 to disassemble instructions in kvm tracepoints (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), it's maintained but not heavily so. Of course for non-x86 we'd need to continue using binutils; this is about copying code vs. libraries, not about licensing. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Xhf-0002ub-Iq for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:44:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9XhZ-0002eY-OB for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:44:47 -0400 Message-ID: <50486270.9020504@redhat.com> Date: Thu, 06 Sep 2012 11:44:32 +0300 From: Avi Kivity MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Anthony Liguori , qemu-ppc , =?UTF-8?B?QW5kcmVhcyBGw6RyYmU=?= =?UTF-8?B?cg==?= On 09/05/2012 10:04 PM, Blue Swirl wrote: > > Reinventing a disassembler for ever growing x86 assembly is > no fun. We can try linking to a disassembler library. I use udis86 to disassemble instructions in kvm tracepoints (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), it's maintained but not heavily so. Of course for non-x86 we'd need to continue using binutils; this is about copying code vs. libraries, not about licensing. -- error compiling committee.c: too many arguments to function