From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dYs-00042W-OJ for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:00:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9dYh-0006NR-HK for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:00:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dYh-0006NF-8G for qemu-devel@nongnu.org; Thu, 06 Sep 2012 10:59:55 -0400 Message-ID: <5048BA26.5080402@redhat.com> Date: Thu, 06 Sep 2012 08:58:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <5048A3C5.7000000@redhat.com> In-Reply-To: <5048A3C5.7000000@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4E364336F709785BD5D3CAEE" Subject: Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: supriyak@linux.vnet.ibm.com, pbonzini@redhat.com, Jeff Cody , qemu-devel@nongnu.org, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4E364336F709785BD5D3CAEE Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 09/06/2012 07:23 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> Add bdrv_find_child(), and bdrv_delete_intermediate(). >> >> bdrv_find_child(): given 'bs' and the active (topmost) BDS of an imag= e chain, >> find the image that is the immediate top of 'bs' >> >> bdrv_delete_intermediate(): > At first, when just reading the function name, I thought this would > actually delete the image file. Of course, it only removes it from the > backing file chain, but leaves the image file around. I don't have a > good suggestion, but if someone has a better name, I think we should > change it. Maybe bdrv_unchain_intermediate()? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4E364336F709785BD5D3CAEE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQSLomAAoJEKeha0olJ0Nq0YUH/jLf2uP/PUyxQdYenlKqgjv1 t+yNwUxHeGlY/mgnUUSPFcLmirZfa7N6FSqeV2NxpS7MVLF930KW0v8JewZ7ZuhC Ruln+9ltUgLa3u6UyLx1ABurF/YxZl2eYJDlojSbYhDCfYItWHKuBIHuyn3VlShL WrqOUZhOWEoB/dz26+FYFydisOANuPtAB1ecNKDwtIM/UgAiXrt4Z/rB6W4zpuJ+ XssXKAhCEuJ1cY8cvGHfenq8XiXeX32maRkDTa8itlVI8DQSDikRxD3mEbX4dwrk KZpJS3ObKTJwUftDaPrVrTembUVmsgZ+H6Ap2X/oG3BMPoWmf09ZHaSo23DIvcI= =YBCF -----END PGP SIGNATURE----- --------------enig4E364336F709785BD5D3CAEE--