From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment Date: Thu, 06 Sep 2012 18:16:48 +0200 Message-ID: <5048CC70.1050208@siemens.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> <5048625F.2060706@siemens.com> <5048CA12.8060200@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Cc: Peter Maydell , "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Blue Swirl , Alex Williamson , Avi Kivity To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Return-path: In-Reply-To: <5048CA12.8060200@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2012-09-06 18:06, Andreas F=E4rber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KV= M >>> interfaces. This version is 100% identical to what is being maintaine= d >>> in qemu-kvm for several years and is supported by libvirt as well. It= is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support ar= e >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is alre= ady >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v3: >>> - addressed comment by Peter (changed device name to kvm-pci-assign = + >>> alias) >>> - addressed (most) comments by Michael >>> - fixed INT pin regression >> >> Does someone _disagree_ that there are no open (and reasonably solvabl= e) >> issues and that this can now be merged through uq/master? >=20 > My implicit suggestion was to add a notice that new patch contributions > to the file from date yyyy-mm-dd on would be declared GPLv2+, as Paolo > has done elsewhere. That would limit the amount of people to ask for a > potential relicensing attempt. Sorry, someone else will have to add this. Personally I think it is pointless to worry about it here anyway as hunting down all contributors and getting them to agree on a GPLv2+ will take longer than the expected lifetime of this component. Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9elD-00056h-3A for qemu-devel@nongnu.org; Thu, 06 Sep 2012 12:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9elB-0007JX-Mv for qemu-devel@nongnu.org; Thu, 06 Sep 2012 12:16:55 -0400 Received: from goliath.siemens.de ([192.35.17.28]:19387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9elB-0007J6-Co for qemu-devel@nongnu.org; Thu, 06 Sep 2012 12:16:53 -0400 Message-ID: <5048CC70.1050208@siemens.com> Date: Thu, 06 Sep 2012 18:16:48 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> <5048625F.2060706@siemens.com> <5048CA12.8060200@suse.de> In-Reply-To: <5048CA12.8060200@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Peter Maydell , "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Blue Swirl , Alex Williamson , Avi Kivity On 2012-09-06 18:06, Andreas F=E4rber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KV= M >>> interfaces. This version is 100% identical to what is being maintaine= d >>> in qemu-kvm for several years and is supported by libvirt as well. It= is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support ar= e >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is alre= ady >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v3: >>> - addressed comment by Peter (changed device name to kvm-pci-assign = + >>> alias) >>> - addressed (most) comments by Michael >>> - fixed INT pin regression >> >> Does someone _disagree_ that there are no open (and reasonably solvabl= e) >> issues and that this can now be merged through uq/master? >=20 > My implicit suggestion was to add a notice that new patch contributions > to the file from date yyyy-mm-dd on would be declared GPLv2+, as Paolo > has done elsewhere. That would limit the amount of people to ask for a > potential relicensing attempt. Sorry, someone else will have to add this. Personally I think it is pointless to worry about it here anyway as hunting down all contributors and getting them to agree on a GPLv2+ will take longer than the expected lifetime of this component. Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux