From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAzHN-0003zH-Jw for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAzHJ-00065s-JK for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:23:37 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:58581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAzHI-00065g-VZ for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:23:33 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Sep 2012 18:21:40 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8A8NJAf20250860 for ; Mon, 10 Sep 2012 18:23:19 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8A8NITW020423 for ; Mon, 10 Sep 2012 18:23:19 +1000 Message-ID: <504DA36F.10204@linux.vnet.ibm.com> Date: Mon, 10 Sep 2012 16:23:11 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1346663926-20188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1346663926-20188-5-git-send-email-xiawenc@linux.vnet.ibm.com> <5044BE96.7080701@redhat.com> <5044CA2F.8000505@redhat.com> <5045AA90.4050001@linux.vnet.ibm.com> <5045E84C.6030902@redhat.com> <504606D9.5070709@redhat.com> <50460765.1080007@redhat.com> In-Reply-To: <50460765.1080007@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , aliguori@us.ibm.com, Eric Blake , qemu-devel@nongnu.org, stefanha@gmail.com Using unit byte now, thanks. > Am 04.09.2012 15:49, schrieb Paolo Bonzini: >> Il 04/09/2012 13:38, Eric Blake ha scritto: >>> Since qemu does not support it now, yes, you can ignore it for now. But >>> please make sure that you aren't hard-coding it into the API - that is, >>> make sure that the API can someday grow to support larger sector sizes >>> with minimal impact to library clients (that is, that new clients aware >>> of the new API can target larger sector size once qemu has been patched >>> to support larger sector size). >> >> We can support 4k sector disks even if the addressing unit remains 512 >> bytes, just like in the Linux kernel. > > Why should we even use an arbitrary unit like 512 bytes for addressing? > To me using byte granularity everywhere makes more sense and is clearer. > > Kevin > -- Best Regards Wenchao Xia