From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx6: add is_boot_from_usb define
Date: Tue, 24 Apr 2018 14:36:47 +0200 [thread overview]
Message-ID: <5050CBB2-4096-4AFB-B5D0-F7888D611CD2@prevas.dk> (raw)
In-Reply-To: <CAOMZO5BC1yH1g5mG6j9H8VgLjd=ytJ_QukiYXUASmCqyjzNXbg@mail.gmail.com>
Hi Fabio
On 24 April 2018 14:13:51 CEST, Fabio Estevam <festevam@gmail.com> wrote:
>Hi Sean,
>
>On Tue, Apr 24, 2018 at 9:05 AM, Sean Nyekjaer
><sean.nyekjaer@prevas.dk> wrote:
>> This enables us to detect if the i.MX6 SoC
>> is booting from USB.
>>
>> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>
>Could you use is_usbotg_phy_active() for this purpose?
>
>Please see:
>
>commit 7d289d6239b29171bf9503869f1a92c084cf1c35
>Author: Stefan Agner <stefan.agner@toradex.com>
>Date: Wed Sep 13 14:29:44 2017 -0700
>
> imx: add macro to detect whether USB PHY is active
>
> This macro allows to detect whether the USB PHY is active. This
> is helpful to detect if the boot ROM has previously started the
> USB serial downloader.
>
> The idea is taken from the mfgtool support in the NXP U-Boot:
>http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/commit/?h=imx_v2016.03_4.1.15_2.0.0_ga&id=a352ed3c5184b95c4c9f7468f5fbb5f43de5e412
Mine was also taken from that commit.
Yes I could use this instead :-) the mx7 is using the same naming as the NXP uboot for the mx6 that why I missed that...
/Sean
>
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
> Reviewed-by: Eric Nelson <eric@nelint.com>
--
Sent from my mobile device. Please excuse my brevity.
prev parent reply other threads:[~2018-04-24 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:05 [U-Boot] [PATCH] imx: mx6: add is_boot_from_usb define Sean Nyekjaer
2018-04-24 12:13 ` Fabio Estevam
2018-04-24 12:36 ` Sean Nyekjær [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5050CBB2-4096-4AFB-B5D0-F7888D611CD2@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.