From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbcBHKwo (ORCPT ); Mon, 8 Feb 2016 05:52:44 -0500 Received: from gloria.sntech.de ([95.129.55.99]:39713 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbcBHKwm (ORCPT ); Mon, 8 Feb 2016 05:52:42 -0500 From: Heiko Stuebner To: Archit Taneja , treding@nvidia.com Cc: Chris Zhong , linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org, Xinliang Liu Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288 Date: Mon, 08 Feb 2016 11:52:21 +0100 Message-ID: <5060470.dfeHX20DRa@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <56B869F4.6090507@codeaurora.org> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <56B869F4.6090507@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Archit, Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja: > On 01/06/2016 09:33 AM, Chris Zhong wrote: > > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > > controller DRM driver. > > > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > > chrome os kernel chrome_v3.14, and it can display normally. > > > > This patchset is base on the patchset from Ying.liu@freescale.com. > > > > > > According to the suggestion from Thierry, I have get rid of the bridge, > > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. > > I've raised this question too late, but what was the reason to not > implement the DSI block as a bridge driver? There seems to always be some sort of contention about those being bridge drivers - I think I remember Thierry speaking up about that. But I don't remember if any different solution was suggested. Also as we have seen with current shared IPs (dw-hdmi + analogix-dp) there are always implementation-specific parts and deciding which needs to land where is difficult without the secondary user present. The first iterations where using a bridge-driver-base for it but I guess it was to much hassle without seeing another user on the horizon. > The drm/hisilicon IP seems to use a very similar DSI Designware IP (the > register offsets seems to be the same). There is a good potential of > re-use here by different kms drivers here the way it's already done for > DW HDMI and the analogix DP driver that's in review process. I guess, the second user now gets to do the generalization ;-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288 Date: Mon, 08 Feb 2016 11:52:21 +0100 Message-ID: <5060470.dfeHX20DRa@phil> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <56B869F4.6090507@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56B869F4.6090507@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , treding@nvidia.com Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgQXJjaGl0LAoKQW0gTW9udGFnLCA4LiBGZWJydWFyIDIwMTYsIDE1OjQyOjA0IHNjaHJpZWIg QXJjaGl0IFRhbmVqYToKPiBPbiAwMS8wNi8yMDE2IDA5OjMzIEFNLCBDaHJpcyBaaG9uZyB3cm90 ZToKPiA+IFRoZSByazMyODggTUlQSSBEU0kgaXMgYSBTeW5vcHN5cyBEZXNpZ25XYXJlIE1JUEkg RFNJIGhvc3QgY29udHJvbGxlcgo+ID4gSVAuIFRoaXMgc2VyaWVzIGFkZHMgc3VwcG9ydCBmb3Ig YSBTeW5vcHN5cyBEZXNpZ25XYXJlIE1JUEkgRFNJIGhvc3QKPiA+IGNvbnRyb2xsZXIgRFJNIGRy aXZlci4KPiA+IAo+ID4gVGhlIE1JUEkgRFNJIGZlYXR1cmUgaXMgdGVzdGVkIG9uIHJrMzI4OCBl dmIgYm9hcmQsIGJhY2twb3J0IHRoZW0gdG8KPiA+IGNocm9tZSBvcyBrZXJuZWwgY2hyb21lX3Yz LjE0LCBhbmQgaXQgY2FuIGRpc3BsYXkgbm9ybWFsbHkuCj4gPiAKPiA+IFRoaXMgcGF0Y2hzZXQg aXMgYmFzZSBvbiB0aGUgcGF0Y2hzZXQgZnJvbSBZaW5nLmxpdUBmcmVlc2NhbGUuY29tLgo+ID4g PGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvZHJpLWRldmVsL21zZzc3MTgxLmh0bWw+Cj4g PiAKPiA+IEFjY29yZGluZyB0byB0aGUgc3VnZ2VzdGlvbiBmcm9tIFRoaWVycnksIEkgaGF2ZSBn ZXQgcmlkIG9mIHRoZSBicmlkZ2UsCj4gPiBhbmQgcmVnaXN0ZXIgdGhlIGVuY29kZXIgJiBjb25u ZWN0ZXIgaW4gZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMuCj4gCj4gSSd2ZSByYWlzZWQgdGhp cyBxdWVzdGlvbiB0b28gbGF0ZSwgYnV0IHdoYXQgd2FzIHRoZSByZWFzb24gdG8gbm90Cj4gaW1w bGVtZW50IHRoZSBEU0kgYmxvY2sgYXMgYSBicmlkZ2UgZHJpdmVyPwoKVGhlcmUgc2VlbXMgdG8g YWx3YXlzIGJlIHNvbWUgc29ydCBvZiBjb250ZW50aW9uIGFib3V0IHRob3NlIGJlaW5nIGJyaWRn ZSAKZHJpdmVycyAtIEkgdGhpbmsgSSByZW1lbWJlciBUaGllcnJ5IHNwZWFraW5nIHVwIGFib3V0 IHRoYXQuIEJ1dCBJIGRvbid0IApyZW1lbWJlciBpZiBhbnkgZGlmZmVyZW50IHNvbHV0aW9uIHdh cyBzdWdnZXN0ZWQuCgpBbHNvIGFzIHdlIGhhdmUgc2VlbiB3aXRoIGN1cnJlbnQgc2hhcmVkIElQ cyAoZHctaGRtaSArIGFuYWxvZ2l4LWRwKSB0aGVyZSAKYXJlIGFsd2F5cyBpbXBsZW1lbnRhdGlv bi1zcGVjaWZpYyBwYXJ0cyBhbmQgZGVjaWRpbmcgd2hpY2ggbmVlZHMgdG8gbGFuZCAKd2hlcmUg aXMgZGlmZmljdWx0IHdpdGhvdXQgdGhlIHNlY29uZGFyeSB1c2VyIHByZXNlbnQuCgpUaGUgZmly c3QgaXRlcmF0aW9ucyB3aGVyZSB1c2luZyBhIGJyaWRnZS1kcml2ZXItYmFzZSBmb3IgaXQgYnV0 IEkgZ3Vlc3MgaXQgCndhcyB0byBtdWNoIGhhc3NsZSB3aXRob3V0IHNlZWluZyBhbm90aGVyIHVz ZXIgb24gdGhlIGhvcml6b24uCgoKPiBUaGUgZHJtL2hpc2lsaWNvbiBJUCBzZWVtcyB0byB1c2Ug YSB2ZXJ5IHNpbWlsYXIgRFNJIERlc2lnbndhcmUgSVAgKHRoZQo+IHJlZ2lzdGVyIG9mZnNldHMg c2VlbXMgdG8gYmUgdGhlIHNhbWUpLiBUaGVyZSBpcyBhIGdvb2QgcG90ZW50aWFsIG9mCj4gcmUt dXNlIGhlcmUgYnkgZGlmZmVyZW50IGttcyBkcml2ZXJzIGhlcmUgdGhlIHdheSBpdCdzIGFscmVh ZHkgZG9uZSBmb3IKPiBEVyBIRE1JIGFuZCB0aGUgYW5hbG9naXggRFAgZHJpdmVyIHRoYXQncyBp biByZXZpZXcgcHJvY2Vzcy4KCkkgZ3Vlc3MsIHRoZSBzZWNvbmQgdXNlciBub3cgZ2V0cyB0byBk byB0aGUgZ2VuZXJhbGl6YXRpb24gOy0pCgoKSGVpa28KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Mon, 08 Feb 2016 11:52:21 +0100 Subject: [PATCH v7 0/5] Add mipi dsi support for rk3288 In-Reply-To: <56B869F4.6090507@codeaurora.org> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <56B869F4.6090507@codeaurora.org> Message-ID: <5060470.dfeHX20DRa@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Archit, Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja: > On 01/06/2016 09:33 AM, Chris Zhong wrote: > > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > > controller DRM driver. > > > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > > chrome os kernel chrome_v3.14, and it can display normally. > > > > This patchset is base on the patchset from Ying.liu at freescale.com. > > > > > > According to the suggestion from Thierry, I have get rid of the bridge, > > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. > > I've raised this question too late, but what was the reason to not > implement the DSI block as a bridge driver? There seems to always be some sort of contention about those being bridge drivers - I think I remember Thierry speaking up about that. But I don't remember if any different solution was suggested. Also as we have seen with current shared IPs (dw-hdmi + analogix-dp) there are always implementation-specific parts and deciding which needs to land where is difficult without the secondary user present. The first iterations where using a bridge-driver-base for it but I guess it was to much hassle without seeing another user on the horizon. > The drm/hisilicon IP seems to use a very similar DSI Designware IP (the > register offsets seems to be the same). There is a good potential of > re-use here by different kms drivers here the way it's already done for > DW HDMI and the analogix DP driver that's in review process. I guess, the second user now gets to do the generalization ;-) Heiko