From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, akong@redhat.com, qemu-devel@nongnu.org,
avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex
Date: Wed, 26 Sep 2012 15:23:36 -0600 [thread overview]
Message-ID: <50637258.4080200@redhat.com> (raw)
In-Reply-To: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On 09/26/2012 02:25 PM, Luiz Capitulino wrote:
> o v3
>
> - doc & log fixups
> - rename KeyCode.hex to KeyCode.number
>
> This actually fixes a regression introduced by the qapi conversion,
> please refer to patch 2/3 for details.
>
> It's also important to note that this series changes the QMP
> interface for the send-key command, but this shouldn't be a problem
> as we're still in development phase.
>
> Luiz Capitulino (3):
> input: qmp_send_key(): simplify
> qmp: qmp_send_key(): accept key codes in hex
> input: index_from_key(): drop unused code
>
> hmp.c | 43 +++++++++++++++++++++-----------
> input.c | 75 ++++++++++++++++++++++++++++----------------------------
> qapi-schema.json | 20 ++++++++++++---
> 3 files changed, 84 insertions(+), 54 deletions(-)
>
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-09-26 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 20:25 [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex Luiz Capitulino
2012-09-26 20:25 ` [Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify Luiz Capitulino
2012-09-27 9:50 ` Markus Armbruster
2012-09-26 20:25 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex Luiz Capitulino
2012-09-27 11:42 ` Markus Armbruster
2012-09-27 12:57 ` Luiz Capitulino
2012-09-26 20:25 ` [Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code Luiz Capitulino
2012-09-26 21:23 ` Eric Blake [this message]
2012-09-27 9:19 ` [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex Avi Kivity
2012-09-27 12:14 ` Luiz Capitulino
2012-09-27 11:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50637258.4080200@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.