From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH, RFC] ext4: don't clear orphan list on ro mount with errors
Date: Wed, 26 Sep 2012 23:32:27 -0500 [thread overview]
Message-ID: <5063D6DB.2000305@redhat.com> (raw)
In-Reply-To: <20120927033211.GE15707@thunk.org>
On 9/26/12 10:32 PM, Theodore Ts'o wrote:
> On Mon, Aug 27, 2012 at 02:27:32PM -0500, Eric Sandeen wrote:
>> When we have a filesystem with an orphan inode list *and* in error
>> state, things behave differently if:
>>
>> 1) e2fsck -p is done prior to mount: e2fsck fixes things and exits
>> happily (barring other significant problems)
>>
>> vs.
>>
>> 2) mount is done first, then e2fsck -p: due to the orphan inode
>> list removal, more errors are found and e2fsck exits with
>> UNEXPECTED INCONSISTENCY.
>>
>> The 2nd case above, on the root filesystem, has the tendency to halt
>> the boot process, which is unfortunate.
>>
>> The situation can be improved by not clearing the orphan
>> inode list when the fs is mounted readonly.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> I've applied this commit since I agree with Jan's observation that if
> the file system is mounted read-only, we should try to minimize
> changes to it if it contains errors. I have modified the commit
> description though:
Fair enough, thanks.
-Eric
> ext4: don't clear orphan list on ro mount with errors
>
> From: Eric Sandeen <sandeen@redhat.com>
>
> If the file system contains errors and it is being mounted read-only,
> don't clear the orphan list. We should minimize changes to the file
> system if it is mounted read-only.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-09-27 4:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 19:12 Why clear the orphan list when mounting a fs with errors? Eric Sandeen
2012-08-27 19:27 ` [PATCH, RFC] ext4: don't clear orphan list on ro mount with errors Eric Sandeen
2012-08-27 23:31 ` Andreas Dilger
2012-08-27 23:35 ` Eric Sandeen
2012-09-27 3:32 ` Theodore Ts'o
2012-09-27 4:32 ` Eric Sandeen [this message]
2012-08-27 19:30 ` [PATCH, RFC] ext3: " Eric Sandeen
2012-08-28 8:02 ` Jan Kara
2012-09-04 18:51 ` Eric Sandeen
2012-09-04 21:27 ` Jan Kara
2012-09-04 19:33 ` Why clear the orphan list when mounting a fs with errors? Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5063D6DB.2000305@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.