From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E38C4360F for ; Wed, 3 Apr 2019 21:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D460F206B7 for ; Wed, 3 Apr 2019 21:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LhAR5MS/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfDCVGn (ORCPT ); Wed, 3 Apr 2019 17:06:43 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54485 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfDCVGn (ORCPT ); Wed, 3 Apr 2019 17:06:43 -0400 Received: by mail-wm1-f66.google.com with SMTP id c1so392472wml.4 for ; Wed, 03 Apr 2019 14:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Jwr2CHtj/NhgYQURHnXg+68kgwW3fE98UM54219zZtU=; b=LhAR5MS/9KMfBOvJbKw0r4e8sfiBGC6bxSMwiS7OHjq26BNW73GMITclxNpPk3sOnR ZU9yAYqkH3K1/e5aGvlv1QurXENuOmBs2uQNGojcpdBoOoqt6uc8p4Vm4NAd5s2PzGPl KdbyE56Sf19bvZrXFkrNyvMOadUqnxY+GVWXUgFz5k1R9LdQj0yPkFeeISg4p36h/ndy QN7x4EgKoS1CbHlJFJneXskeY2SJ0ByCkK+b5B2HmBDLk757adZLliKK2PBXn79wxaqg On60eXLBNm9TdBuJiDm2WKSbuUFNZTz4pC5XDAiQVHLTu+aEAuJs/NXEBb9NYM/i8sHa s4Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jwr2CHtj/NhgYQURHnXg+68kgwW3fE98UM54219zZtU=; b=XSkpI2NNYRpwq/76OJ8Wn9FPPy131UgMK6HUEWbM6ODW+9IUiK/0IvG8MAr70AW0df EliADpbx+ovy5EgPqp7K3qHroBVn61UouDD2JDMIax8iiRZhu4F3syEYIzJwS5tgIQTZ 9uMsfsxGTWZjWZYTadL97i1mIM15fTX+BJvvFcmHpv4z9IotDuWtVMxPNUoFUVVGrcqH bN8Hg0GHVDq7xAUGwYJnQKvsEn4PXjH4ERSaGA8J7sppaV9ivaJOf4XswfRh3Eq29ZHi Iv354RG25w0vV9OyH8zOPX2OkhfiUJ14WDR9jEfNhdodr8Bpm0GFv7I9U99c+S2GMB39 odEw== X-Gm-Message-State: APjAAAWXVHytRYlTfiL1rz2RtjKLD6/16x1CdnvDqXe/nUlx1IdTNX7i 0rNDKeFR3gN+wXx8L0U/kQONz5QA X-Google-Smtp-Source: APXvYqyHJsBTCWNnOBWXTaqlceCUoU/rovjdThYs5jDwt7uKUohmnzMULn2+RQIGC+Bp4mtiJpgI3w== X-Received: by 2002:a1c:2b41:: with SMTP id r62mr1501096wmr.94.1554325600862; Wed, 03 Apr 2019 14:06:40 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:ed2b:516:5ae8:487f? (p200300EA8BE1DD00ED2B05165AE8487F.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:ed2b:516:5ae8:487f]) by smtp.googlemail.com with ESMTPSA id v14sm19822789wrr.20.2019.04.03.14.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 14:06:40 -0700 (PDT) Subject: Re: [PATCH net-next 1/2] net: phy: allow a PHY driver to define neither features nor get_features To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <20190403204658.GF4592@lunn.ch> From: Heiner Kallweit Message-ID: <5067db4b-33fc-5737-8c05-5ab41c50f25a@gmail.com> Date: Wed, 3 Apr 2019 22:59:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403204658.GF4592@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03.04.2019 22:46, Andrew Lunn wrote: >> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner) >> /* Either the features are hard coded, or dynamically >> * determine. It cannot be both or neither >> */ > > Hi Heiner > > The comment needs updating to match the code. > Indeed, I have to fix this. >> - if (WARN_ON((!new_driver->features && !new_driver->get_features) || >> - (new_driver->features && new_driver->get_features))) { >> - pr_err("%s: Driver features are missing\n", new_driver->name); >> + if (WARN_ON(new_driver->features && new_driver->get_features)) { >> + pr_err("%s: features and get_features must not both be set\n", >> + new_driver->name); >> return -EINVAL; > > Andrew >