From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267Ab2I3LNY (ORCPT ); Sun, 30 Sep 2012 07:13:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9516 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786Ab2I3LNW (ORCPT ); Sun, 30 Sep 2012 07:13:22 -0400 Message-ID: <50682945.3060309@redhat.com> Date: Sun, 30 Sep 2012 13:13:09 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Gleb Natapov CC: Raghavendra K T , Jiannan Ouyang , Peter Zijlstra , Rik van Riel , "H. Peter Anvin" , Ingo Molnar , Marcelo Tosatti , Srikar , "Nikunj A. Dadhania" , KVM , chegu vinod , "Andrew M. Theurer" , LKML , Srivatsa Vaddagiri Subject: Re: [PATCH RFC 1/2] kvm: Handle undercommitted guest case in PLE handler References: <505CA2EB.7050403@linux.vnet.ibm.com> <50607F1F.2040704@redhat.com> <5060851E.1030404@redhat.com> <506166B4.4010207@linux.vnet.ibm.com> <5061713D.5060406@redhat.com> <50641356.5070008@redhat.com> <506540C7.9070105@linux.vnet.ibm.com> <50680049.5020206@redhat.com> <20120930110755.GB1009@redhat.com> In-Reply-To: <20120930110755.GB1009@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2012 01:07 PM, Gleb Natapov wrote: > On Sun, Sep 30, 2012 at 10:18:17AM +0200, Avi Kivity wrote: >> On 09/28/2012 08:16 AM, Raghavendra K T wrote: >> > >> >> >> >> +struct pv_sched_info { >> >> + unsigned long sched_bitmap; >> > >> > Thinking, whether we need something similar to cpumask here? >> > Only thing is we are representing guest (v)cpumask. >> > >> >> DECLARE_BITMAP(sched_bitmap, KVM_MAX_VCPUS) >> > vcpu_id can be greater than KVM_MAX_VCPUS. Use the index into the vcpu table as the bitmap index then. In fact it's better because then the lookup to get the vcpu pointer is trivial. -- error compiling committee.c: too many arguments to function