On 10/04/2012 03:59 PM, Andreas Larsson wrote: > Signed-off-by: Andreas Larsson Looks better. However on sparc and sparc64, I'm seeing this warning. From my point of view a false positive. > linux/drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_remove': > linux/include/linux/ioport.h:165:18: warning: 'res.end' is used uninitialized in this function [-Wuninitialized] > linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.end' was declared here > linux/include/linux/ioport.h:165:2: warning: 'res.start' is used uninitialized in this function [-Wuninitialized] > linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.start' was declared here I'm using these compilers: http://kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/x86_64-gcc-4.6.3-nolibc_sparc-linux.tar.xz http://kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/x86_64-gcc-4.6.3-nolibc_sparc64-linux.tar.xz Can you please compile your kernel with these and test if this works: while true; do rmmod sja1000_of_platform; modprobe sja1000_of_platform; done Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |