On 10/04/2012 04:42 PM, Marc Kleine-Budde wrote: > On 10/04/2012 03:59 PM, Andreas Larsson wrote: >> Signed-off-by: Andreas Larsson > > Looks better. However on sparc and sparc64, I'm seeing this warning. > From my point of view a false positive. > >> linux/drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_remove': >> linux/include/linux/ioport.h:165:18: warning: 'res.end' is used uninitialized in this function [-Wuninitialized] >> linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.end' was declared here >> linux/include/linux/ioport.h:165:2: warning: 'res.start' is used uninitialized in this function [-Wuninitialized] >> linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.start' was declared here Looking at the preprocessed code, the compiler is right: > # 30 "/home/frogger/pengutronix/socketcan/linux/include/linux/of_address.h" > static inline __attribute__((always_inline)) __attribute__((no_instrument_function)) int of_address_to_resource(struct device_node *dev, int index, > struct resource *r) > { > return -22; > } http://lxr.free-electrons.com/source/include/linux/of_address.h#L29 Why is CONFIG_OF_ADDRESS not set in my .config? http://lxr.free-electrons.com/source/drivers/of/Kconfig#L43 What a U+1F4A9, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |