From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2yn-0005NY-1L
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:09:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2yh-0004Ee-Ba
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:09:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25927)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2yh-0004EU-3c
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:09:47 -0400
Message-ID: <506E95BD.2010709@redhat.com>
Date: Fri, 05 Oct 2012 10:09:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349372021-31212-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1349372021-31212-8-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1349372021-31212-8-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 07/22] qapi: qapi_visit.py,
 support for visiting non-pointer/embedded structs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com

Il 04/10/2012 19:33, Michael Roth ha scritto:
> +                elif argentry.has_key('<embedded struct>'):

Just <embedded> perhaps?

Paolo

> +                    tmp_ptr_name = "%s_%s_ptr" % (c_var(field_prefix).replace(".", ""), c_var(argname))
> +                    ret += mcgen('''
> +%(type)s *%(tmp_ptr)s = &(*obj)->%(c_prefix)s%(c_name)s;
> +visit_type_%(type)s(m, (obj && *obj) ? &%(tmp_ptr)s : NULL, "%(name)s", errp);
> +''',
> +                                 c_prefix=c_var(field_prefix), prefix=field_prefix,
> +                                 type=type_name(argentry['type']), c_name=c_var(argname),
> +                                 name=argname, tmp_ptr=tmp_ptr_name)