From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 3 of 8] xen: let the (credit) scheduler know
 about `node affinity`
Date: Fri, 05 Oct 2012 15:25:58 +0100
Message-ID: <506F0A1602000078000A00F4@nat28.tlf.novell.com>
References: <patchbomb.1349446098@Solace>
	<ca2fa958879bbffa9bc6.1349446101@Solace>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <ca2fa958879bbffa9bc6.1349446101@Solace>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>, Ian Campbell <Ian.Campbell@citrix.com>, Marcus Granado <Marcus.Granado@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Anil Madhavapeddy <anil@recoil.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org, Matt Wilson <msw@amazon.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

>>> On 05.10.12 at 16:08, Dario Faggioli <dario.faggioli@citrix.com> wrote:
> @@ -287,22 +344,26 @@ static inline void
>          }
>          else
>          {
> -            cpumask_t idle_mask;
> +            cpumask_t idle_mask, balance_mask;

Be _very_ careful about adding on-stack CPU mask variables
(also further below): each one of them grows the stack frame
by 512 bytes (when building for the current maximum of 4095
CPUs), which is generally too much; you may want to consider
pre-allocated scratch space instead.

Jan