From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C11CCC43219 for ; Thu, 25 Apr 2019 23:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A614F206C1 for ; Thu, 25 Apr 2019 23:50:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=akamai.com header.i=@akamai.com header.b="Fwa9zB/B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726719AbfDYXuu (ORCPT ); Thu, 25 Apr 2019 19:50:50 -0400 Received: from mx0b-00190b01.pphosted.com ([67.231.157.127]:45618 "EHLO mx0b-00190b01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfDYXuu (ORCPT ); Thu, 25 Apr 2019 19:50:50 -0400 Received: from pps.filterd (m0122331.ppops.net [127.0.0.1]) by mx0b-00190b01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3PNgZmm007246; Fri, 26 Apr 2019 00:50:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=OE91TeTWuqF/SjK7R9bwdfKyeNsx9RL/kJbjymdTJzk=; b=Fwa9zB/Bh5NF15e8mvHXiY0pQHm3gvzI8InZda7M2qHkUlea3RKRGmXetEPjue9FpqQ7 KG0oYnrUbg8rmBwbh3qtk0Ljz6pg3pmi4JJ7HkkFxU2/zgl6n4qsUbfj1Sy5Pu1q8G8V t/srQM4ATtRqmXnuIoZRZ8pdEwD2Nxx9ZEx/Wxr4MkTt2n5jlqk4cJgGa+xM0luM2p4r +VIHokED4VN48LlgliKqXfItNrsW8IMATDo89AVF63M1oIEBnKw75wptdkPVnMATDyJ8 V1BzZX0Vf9WypEvMsg84CYTadkASJ1nFrllxAC+tklWyVJ0ICr15Y8cSnfwNfQkoARlV 7Q== Received: from prod-mail-ppoint2 (prod-mail-ppoint2.akamai.com [184.51.33.19] (may be forged)) by mx0b-00190b01.pphosted.com with ESMTP id 2s3mwrraus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2019 00:50:47 +0100 Received: from pps.filterd (prod-mail-ppoint2.akamai.com [127.0.0.1]) by prod-mail-ppoint2.akamai.com (8.16.0.27/8.16.0.27) with SMTP id x3PNkac7015056; Thu, 25 Apr 2019 19:50:46 -0400 Received: from prod-mail-relay11.akamai.com ([172.27.118.250]) by prod-mail-ppoint2.akamai.com with ESMTP id 2ryxrw6kx8-1; Thu, 25 Apr 2019 19:50:46 -0400 Received: from [0.0.0.0] (prod-ssh-gw01.bos01.corp.akamai.com [172.27.119.138]) by prod-mail-relay11.akamai.com (Postfix) with ESMTP id 8519D1FC72; Thu, 25 Apr 2019 23:50:42 +0000 (GMT) Subject: Re: [PATCH iproute2-next] ss: add option to print socket information on one line To: Stephen Hemminger Cc: netdev@vger.kernel.org References: <1556227308-16057-1-git-send-email-johunt@akamai.com> <20190425155951.26d91cc6@hermes.lan> From: Josh Hunt Message-ID: <506a820f-6e31-5e03-6283-08d087649e26@akamai.com> Date: Thu, 25 Apr 2019 16:50:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190425155951.26d91cc6@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-25_19:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904250145 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-25_19:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904250145 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/25/19 3:59 PM, Stephen Hemminger wrote: > On Thu, 25 Apr 2019 17:21:48 -0400 > Josh Hunt wrote: > >> Multi-line output in ss makes it difficult to search for things with >> grep. This new option will make it easier to find sockets matching >> certain criteria with simple grep commands. >> >> Example without option: >> $ ss -emoitn >> State Recv-Q Send-Q Local Address:Port Peer Address:Port >> ESTAB 0 0 127.0.0.1:13265 127.0.0.1:36743 uid:1974 ino:48271 sk:1 <-> >> skmem:(r0,rb2227595,t0,tb2626560,f0,w0,o0,bl0,d0) ts sack reno wscale:7,7 rto:211 rtt:10.245/16.616 ato:40 mss:65483 cwnd:10 bytes_acked:41865496 bytes_received:21580440 segs_out:242496 segs_in:351446 data_segs_out:242495 data_segs_in:242495 send 511.3Mbps lastsnd:2383 lastrcv:2383 lastack:2342 pacing_rate 1022.6Mbps rcv_rtt:92427.6 rcv_space:43725 minrtt:0.007 >> >> Example with new option: >> $ ss -emoitnO >> State Recv-Q Send-Q Local Address:Port Peer Address:Port >> ESTAB 0 0 127.0.0.1:13265 127.0.0.1:36743 uid:1974 ino:48271 sk:1 <-> skmem:(r0,rb2227595,t0,tb2626560,f0,w0,o0,bl0,d0) ts sack reno wscale:7,7 rto:211 rtt:10.067/16.429 ato:40 mss:65483 pmtu:65535 rcvmss:536 advmss:65483 cwnd:10 bytes_sent:41868244 bytes_acked:41868244 bytes_received:21581866 segs_out:242512 segs_in:351469 data_segs_out:242511 data_segs_in:242511 send 520.4Mbps lastsnd:14355 lastrcv:14355 lastack:14314 pacing_rate 1040.7Mbps delivery_rate 74837.7Mbps delivered:242512 app_limited busy:1861946ms rcv_rtt:92427.6 rcv_space:43725 rcv_ssthresh:43690 minrtt:0.007 >> >> Signed-off-by: Josh Hunt > > I agree with this, but probably time to give ss a json output as well. > OK sure. Do you want to take both in a series or will you take this now with a separate json patch later? Josh