From: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 5/5] KVM: MMU: introduce FNAME(prefetch_gpte)
Date: Thu, 11 Oct 2012 21:12:51 +0800 [thread overview]
Message-ID: <5076C5D3.6020104@gmail.com> (raw)
In-Reply-To: <20121010152144.GA29776@amt.cnet>
On 10/10/2012 11:21 PM, Marcelo Tosatti wrote:
>> pgprintk("%s: gpte %llx spte %p\n", __func__, (u64)gpte, spte);
>> +
>> + gfn = gpte_to_gfn(gpte);
>> pte_access = sp->role.access & gpte_access(vcpu, gpte);
>> protect_clean_gpte(&pte_access, gpte);
>> - pfn = gfn_to_pfn_atomic(vcpu->kvm, gpte_to_gfn(gpte));
>> + pfn = pte_prefetch_gfn_to_pfn(vcpu, gfn,
>> + no_dirty_log && (pte_access & ACC_WRITE_MASK));
>
> Is this a bugfix?
No. It is a cleanup.
Actually, pte_prefetch_gfn_to_pfn(vcpu, gfn, false) is the same as
gfn_to_pfn_atomic
prev parent reply other threads:[~2012-10-11 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 12:00 [PATCH v4 0/5] KVM: MMU: fix release no-slot pfn and clean up mmu code Xiao Guangrong
2012-10-07 12:01 ` [PATCH v4 1/5] KVM: MMU: fix release noslot pfn Xiao Guangrong
2012-10-10 15:11 ` Marcelo Tosatti
2012-10-11 13:06 ` Xiao Guangrong
2012-10-11 14:31 ` Marcelo Tosatti
2012-10-12 9:49 ` Xiao Guangrong
2012-10-14 16:36 ` Marcelo Tosatti
2012-10-07 12:02 ` [PATCH v4 2/5] KVM: MMU: remove mmu_is_invalid Xiao Guangrong
2012-10-07 12:02 ` [PATCH v4 3/5] KVM: MMU: cleanup FNAME(page_fault) Xiao Guangrong
2012-10-07 12:03 ` [PATCH v4 4/5] KVM: MMU: move prefetch_invalid_gpte out of pagaing_tmp.h Xiao Guangrong
2012-10-07 12:05 ` [PATCH v4 5/5] KVM: MMU: introduce FNAME(prefetch_gpte) Xiao Guangrong
2012-10-10 15:21 ` Marcelo Tosatti
2012-10-11 13:12 ` Xiao Guangrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5076C5D3.6020104@gmail.com \
--to=xiaoguangrong.eric@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.