From: Kevin Wolf <kwolf@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure
Date: Mon, 15 Oct 2012 10:52:37 +0200 [thread overview]
Message-ID: <507BCED5.9040808@redhat.com> (raw)
In-Reply-To: <20121012213952.GR16157@illuin>
Am 12.10.2012 23:39, schrieb Michael Roth:
> On Fri, Oct 05, 2012 at 10:24:30AM +0200, Paolo Bonzini wrote:
>> Il 04/10/2012 19:33, Michael Roth ha scritto:
>>> +
>>> +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py qidl.py qidl_parser.py qapi.py qapi_visit.py)
>>> + $(call rm -f $(*D)/qidl-generated/$(*F).qidl.c)
>>> + $(if $(strip $(shell grep "QIDL_ENABLE()" $< 1>/dev/null && echo "true")), \
>>> + $(call quiet-command, \
>>> + $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(CFLAGS) -E -c -DQIDL_GEN $< | \
>>> + $(PYTHON) $(SRC_PATH)/scripts/qidl.py \
>>> + --output-filepath=$(*D)/qidl-generated/$(*F).qidl.c || [ "$$?" -eq 2 ], \
>>> + "qidl PP $(*D)/$(*F).c"),)
>>> +%.o: %.c %.qidl.c
>>> + $(if $(strip $(shell test -f $(*D)/qidl-generated/$(*F).qidl.c && echo "true")), \
>>> + $(call quiet-command, \
>>> + $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
>>> + -DQIDL_ENABLED -include $< -o $@ $(*D)/qidl-generated/$(*F).qidl.c, \
>>> + "qidl CC $@"), \
>>> + $(call quiet-command, \
>>> + $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
>>> + -o $@ $<," CC $@"))
>>
>>
>> Because the .qidl.c files are not created for files without a QIDL_ENABLE()
>> directive, all those files will be grepped on every invocation of the makefile.
>>
>> It is better to define the list of QIDL_ENABLEd files in an auxiliary makefile
>> like this (untested):
>
> Thanks for the suggestion / example.
>
> FYI, I tried to get this working but didn't manage to get it in for v4. Everything
> seems to be falling back to the non-qidl %o: target, and I haven't had time to
> debug it.
>
> FWIW, it doesn't seem to be a major factor performance-wise. Current build
> times on my laptop are (for all-target builds):
>
> QIDL v4:
> real 8m35.383s
> user 31m1.844s
> sys 1m33.998s
>
> upstream:
> real 8m28.181s
> user 30m44.983s
> sys 1m29.926s
Isn't the more interesting case that I only touched block/qcow2.c and
run make to update my binaries? I haven't really looked at the code, but
Paolo's comment suggests that even in this case a lot of files would be
grepped, and I think that losing a few seconds in such cases would
really hurt.
Kevin
next prev parent reply other threads:[~2012-10-15 8:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 17:33 [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 01/22] qapi: qapi-visit.py -> qapi_visit.py so we can import Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 02/22] qapi: qapi-types.py -> qapi_types.py Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 03/22] qapi: qapi-commands.py -> qapi_commands.py Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 04/22] qapi: qapi_visit.py, make code useable as module Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 05/22] qapi: qapi_visit.py, support arrays and complex qapi definitions Michael Roth
2012-10-05 8:11 ` Paolo Bonzini
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 06/22] qapi: qapi_visit.py, support generating static functions Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 07/22] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs Michael Roth
2012-10-05 8:09 ` Paolo Bonzini
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 08/22] qapi: add visitor interfaces for C arrays Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 09/22] qapi: QmpOutputVisitor, implement array handling Michael Roth
2012-10-05 8:05 ` Paolo Bonzini
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 10/22] qapi: QmpInputVisitor, " Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 11/22] qapi: qapi.py, make json parser more robust Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 12/22] qapi: add open-coded visitor for struct tm types Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 13/22] qom-fuse: force single-threaded mode to avoid QMP races Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 14/22] qom-fuse: workaround for truncated properties > 4096 Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 15/22] module additions for schema registration Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 16/22] qdev: move Property-related declarations to qdev-properties.h Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 17/22] qidl: add documentation Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 18/22] qidl: add lexer library (based on QC parser) Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 19/22] qidl: add C parser " Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 20/22] qidl: add QAPI-based code generator Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations Michael Roth
2012-10-05 8:14 ` Paolo Bonzini
2012-10-05 14:50 ` Michael Roth
2012-10-05 15:07 ` Paolo Bonzini
2012-10-05 15:41 ` Michael Roth
2012-10-05 15:53 ` Paolo Bonzini
2012-10-05 16:47 ` Michael Roth
2012-10-15 13:37 ` Paolo Bonzini
2012-10-15 15:50 ` Michael Roth
2012-10-04 17:33 ` [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure Michael Roth
2012-10-05 8:24 ` Paolo Bonzini
2012-10-12 21:39 ` Michael Roth
2012-10-13 7:12 ` Paolo Bonzini
2012-10-15 8:52 ` Kevin Wolf [this message]
2012-10-15 14:48 ` Michael Roth
2012-10-05 8:26 ` [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization Paolo Bonzini
2012-10-05 14:52 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507BCED5.9040808@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.