From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 01/10] pinctrl: use postcore_initcall Date: Thu, 18 Oct 2012 16:18:19 -0600 Message-ID: <5080802B.3000209@wwwdotorg.org> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1350551224-12857-1-git-send-email-haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Haojian Zhuang Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/18/2012 03:06 AM, Haojian Zhuang wrote: > Since pins are configured in device driver, pinctrl driver should be > loaded by those device driver. module_platform_driver() only declares > pinctrl driver is in module_initcall privilege. Use postcore_initcall > privilege instead. I'm not convinced this is needed; doesn't deferred probe sort out the dependencies correctly? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 18 Oct 2012 16:18:19 -0600 Subject: [PATCH 01/10] pinctrl: use postcore_initcall In-Reply-To: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> Message-ID: <5080802B.3000209@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/18/2012 03:06 AM, Haojian Zhuang wrote: > Since pins are configured in device driver, pinctrl driver should be > loaded by those device driver. module_platform_driver() only declares > pinctrl driver is in module_initcall privilege. Use postcore_initcall > privilege instead. I'm not convinced this is needed; doesn't deferred probe sort out the dependencies correctly?