From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gerg@uclinux.org>) id 1bpadO-0007sC-Ty
	for qemu-devel@nongnu.org; Thu, 29 Sep 2016 08:40:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gerg@uclinux.org>) id 1bpadL-0005DF-CU
	for qemu-devel@nongnu.org; Thu, 29 Sep 2016 08:40:18 -0400
References: <1475021199-28674-1-git-send-email-gerg@uclinux.org>
	<d5a78365-a0a9-d208-442b-32c4f35c5daf@vivier.eu>
	<d1ddd6de-5b17-cad0-f6a1-79ca89896949@tuxfamily.org>
From: Greg Ungerer <gerg@uclinux.org>
Message-ID: <5082bb5b-1fba-c70f-89fc-2177165d4ffc@uclinux.org>
Date: Thu, 29 Sep 2016 22:39:55 +1000
MIME-Version: 1.0
In-Reply-To: <d1ddd6de-5b17-cad0-f6a1-79ca89896949@tuxfamily.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCHv2] m68k: change default system clock for
 m5208evb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <huth@tuxfamily.org>, Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

Hi Thomas,

On 29/09/16 17:56, Thomas Huth wrote:
> On 29.09.2016 09:50, Laurent Vivier wrote:
>>
>>
>> Le 28/09/2016 à 02:06, Greg Ungerer a écrit :
>>> The shipping default setting for the Freescale M5208EVB board is to run
>>> the CPU at 166.67MHz. The current qemu emulation code for this board is
>>> defaulting to 66MHz. This results in time appearing to run way to slowly.
>>> So a "sleep 5" in a standard ColdFire Linux build takes almost 15
>>> seconds in real time to actually complete.
>>>
>>> Change the hard coded default to match the default hardware setting.
>>>
>>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>>
>> This solution is as good as another, so:
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Fine for me, too, so:
>
> Reviewed-by: Thomas Huth <huth@tuxfamily.org>

Thanks for the review.

Regards
Greg


> By the way, we still do not have a m68k maintainer yet ... Laurent,
> maybe you could finally send a pull request for that patch here:
> https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00805.html ?
>
> Meanwhile, Peter, could you please take this patch here from Greg
> directly? Or should it go via qemu-trivial instead?
>
>  Thomas
>
>
>>> ---
>>>  hw/m68k/mcf5208.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> v2: more accurately set frequency (166666666 instead of 166000000)
>>>
>>> diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
>>> index 9240ebf..3438314 100644
>>> --- a/hw/m68k/mcf5208.c
>>> +++ b/hw/m68k/mcf5208.c
>>> @@ -21,7 +21,7 @@
>>>  #include "elf.h"
>>>  #include "exec/address-spaces.h"
>>>
>>> -#define SYS_FREQ 66000000
>>> +#define SYS_FREQ 166666666
>>>
>>>  #define PCSR_EN         0x0001
>>>  #define PCSR_RLD        0x0002
>>>
>>
>
>