From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQAXX-0003Ts-V8 for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:27:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQAXX-0006y9-2p for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:27:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQAXW-0006y5-Qq for qemu-devel@nongnu.org; Mon, 22 Oct 2012 01:27:03 -0400 Message-ID: <5084D91D.9040003@redhat.com> Date: Mon, 22 Oct 2012 07:26:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1350480554-23281-1-git-send-email-kraxel@redhat.com> <1350480554-23281-8-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "qemu-devel@nongnu.org" On 10/19/12 19:02, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Gerd Hoffmann wrote: >> Currently it is inconstent, PixelFormat->amask is left unset whereas >> abits and amax and ashift are filled. As an alpha channel doesn't make >> sense for the vga framebuffer leave all alpha fields clear. >> >> Signed-off-by: Gerd Hoffmann > > Actually the alpha mask was left to 0 on purpose to ignore it. > At the same time we set amax, ashift and abits to signal the presence of > an alpha byte in the pixel format. Hmm? I still don't see t he point of the current mix. Either the byte is alpha or it is unused ... cheers, Gerd