From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479Ab2JVKOB (ORCPT ); Mon, 22 Oct 2012 06:14:01 -0400 Received: from mx2.parallels.com ([64.131.90.16]:36757 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863Ab2JVKN7 (ORCPT ); Mon, 22 Oct 2012 06:13:59 -0400 Message-ID: <50851C54.9080600@parallels.com> Date: Mon, 22 Oct 2012 14:13:40 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Christoph Lameter CC: , , , Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , , David Rientjes , Pekka Enberg , , Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-11-git-send-email-glommer@parallels.com> <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2012 11:44 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> struct page already have this information. If we start chaining >> caches, this information will always be more trustworthy than >> whatever is passed into the function > > Yes it does but the information is not standardized between the allocators > yet. Coul you unify that? Come out with a struct page overlay that is as > much the same as possible. Then kfree can also be unified because the > lookup is always the same. That way you can move kfree into slab_common > and avoid modifying multiple allocators. > Ok, this is yet another changelog mistake from mine. This function is not about kfree, but kmem_cache_free. But part of your comment still applies, the page lookup can still be common. I will take a look at that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id D04766B0062 for ; Mon, 22 Oct 2012 06:14:00 -0400 (EDT) Message-ID: <50851C54.9080600@parallels.com> Date: Mon, 22 Oct 2012 14:13:40 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-11-git-send-email-glommer@parallels.com> <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On 10/19/2012 11:44 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> struct page already have this information. If we start chaining >> caches, this information will always be more trustworthy than >> whatever is passed into the function > > Yes it does but the information is not standardized between the allocators > yet. Coul you unify that? Come out with a struct page overlay that is as > much the same as possible. Then kfree can also be unified because the > lookup is always the same. That way you can move kfree into slab_common > and avoid modifying multiple allocators. > Ok, this is yet another changelog mistake from mine. This function is not about kfree, but kmem_cache_free. But part of your comment still applies, the page lookup can still be common. I will take a look at that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree Date: Mon, 22 Oct 2012 14:13:40 +0400 Message-ID: <50851C54.9080600@parallels.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-11-git-send-email-glommer@parallels.com> <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Christoph Lameter Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, David Rientjes , Pekka Enberg , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Pekka Enberg , Suleiman Souhlal On 10/19/2012 11:44 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> struct page already have this information. If we start chaining >> caches, this information will always be more trustworthy than >> whatever is passed into the function > > Yes it does but the information is not standardized between the allocators > yet. Coul you unify that? Come out with a struct page overlay that is as > much the same as possible. Then kfree can also be unified because the > lookup is always the same. That way you can move kfree into slab_common > and avoid modifying multiple allocators. > Ok, this is yet another changelog mistake from mine. This function is not about kfree, but kmem_cache_free. But part of your comment still applies, the page lookup can still be common. I will take a look at that.