From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQFOM-0006C5-4Z for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:37:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQFOG-0002IW-DL for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:37:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQFOG-0002IL-4C for qemu-devel@nongnu.org; Mon, 22 Oct 2012 06:37:48 -0400 Message-ID: <508521F3.3070008@redhat.com> Date: Mon, 22 Oct 2012 12:37:39 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20121021124303.GA5096@redhat.com> <5084E088.9090602@redhat.com> <20121022100821.GB24424@redhat.com> In-Reply-To: <20121022100821.GB24424@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com On 10/22/12 12:08, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> Would it make sense to temporarily rename the machine type e.g. >>> pc-q35-experimental to stress it's not fully supported? >> >> I don't think this is needed as piix will continue to be the default. > > Well q35 is not yet 100% ready. I know. > The point was to hide it from libvirt. > libvirt should support pc-q35 not pc-q35-experimental, then > it will not cause trouble. You'll not going to hide it that way. Libvirt will just 'qemu -M ?' where q35 will show up even if you rename it to be postfixed -experimental. But as long as 'pc' continues to be the default the causal user will never ever notice q35 is there, at least not with virt-manager (dunno about boxes) as there is simply no gui way to pick the machine type. You'll have to explicitly "virsh edit $guest" to switch it to q35. So I'm not sure what you are worryed about. But in any case this needs discussion with the libvirt folks to make sure it will actually work as intended. /me tends to think a experimental bit in machine_info (which is then printed by 'qemu -M ?' and the QOM-version of that) is more useful than playing tricks with the name. cheers, Gerd