From: Adam Jackson <ajax@redhat.com>
To: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
Cc: dri-devel@lists.freedesktop.org,
Benjamin Herrenschmidt <benh@au1.ibm.com>,
linux-pci@vger.kernel.org,
Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Brian King <brking@linux.vnet.ibm.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: radeon: RFC speed cap detection on ppc64
Date: Mon, 22 Oct 2012 11:27:54 -0400 [thread overview]
Message-ID: <508565FA.4040908@redhat.com> (raw)
In-Reply-To: <50819140.8030806@linux.vnet.ibm.com>
On 10/19/12 1:43 PM, Lucas Kannebley Tavares wrote:
> The radeon driver does speed cap detection on the root PCI device for
> the maximum speed with which the adapter can communicate. On ppc64
> systems, however, the root device belongs to the Hypervisor, so the
> current code would case a null pointer dereference.
>
> I propose to look for the outmost bus with a parent node and get speed
> caps from it, though I suppose the cleaner way would be to inspect all
> devices along the way and choose the smallest speed cap.
That (walking all parent nodes) is probably the safest thing to do. I'm
not sure whether it's optimal. It would likely depend on whether you
can meaningfully have a bridge that's faster on the downstream side than
on the upstream.
- ajax
next prev parent reply other threads:[~2012-10-22 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 17:43 radeon: RFC speed cap detection on ppc64 Lucas Kannebley Tavares
2012-10-22 15:27 ` Adam Jackson [this message]
2012-10-22 15:44 ` Alan Cox
2012-10-22 16:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508565FA.4040908@redhat.com \
--to=ajax@redhat.com \
--cc=benh@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucaskt@linux.vnet.ibm.com \
--cc=nacc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.