All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>,
	mchehab@kernel.org, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, yj.chiang@mediatek.com
Subject: Re: [PATCH] media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y
Date: Tue, 12 Oct 2021 10:23:08 +0200	[thread overview]
Message-ID: <5086eb11-621f-29ed-e2dd-2a262857b78c@xs4all.nl> (raw)
In-Reply-To: <20211005105110.14082-1-lecopzer.chen@mediatek.com>

On 05/10/2021 12:51, Lecopzer Chen wrote:
> A case that we need VIDEO_DEV=y but DVB_CORE=m, and this doesn't
> work since DVB_CORE is default MEDIA_DIGITAL_TV_SUPPORT and then
> follows MEDIA_SUPPORT.
> 
> Change to tristate to make DVB_CORE=m possible when MEDIA_SUPPORT=y
> 
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> ---
>  drivers/media/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index b07812657cee..c3baf92b4d02 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
>  		will disable support for them.
>  
>  config MEDIA_DIGITAL_TV_SUPPORT
> -	bool
> +	tristate
>  	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
>  	default y if !MEDIA_SUPPORT_FILTER
>  	help
> 

I don't think this is the right approach.

I think the following patch would fix the issue, and it is also in line
with what config VIDEO_DEV does.

What do you think, Mauro?

Regards,

	Hans

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index c3baf92b4d02..46f7b1f75630 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -179,8 +179,7 @@ config MEDIA_CONTROLLER
 #

 config DVB_CORE
-	tristate
-	depends on MEDIA_DIGITAL_TV_SUPPORT
+	tristate "DVB core"
 	depends on (I2C || I2C=n)
 	default MEDIA_DIGITAL_TV_SUPPORT
 	select CRC32

  parent reply	other threads:[~2021-10-12  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 10:51 [PATCH] media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y Lecopzer Chen
2021-10-05 16:31 ` Mauro Carvalho Chehab
2021-10-06  3:26   ` Lecopzer Chen
2021-10-12  8:23 ` Hans Verkuil [this message]
2021-11-03  8:05   ` Lecopzer Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5086eb11-621f-29ed-e2dd-2a262857b78c@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=lecopzer.chen@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.