From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933836Ab2JXIms (ORCPT ); Wed, 24 Oct 2012 04:42:48 -0400 Received: from mx2.parallels.com ([64.131.90.16]:33562 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933455Ab2JXImq (ORCPT ); Wed, 24 Oct 2012 04:42:46 -0400 Message-ID: <5087A9F7.7070804@parallels.com> Date: Wed, 24 Oct 2012 12:42:31 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: JoonSoo Kim CC: , , , Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , , Christoph Lameter , David Rientjes , Pekka Enberg , , Suleiman Souhlal , Pekka Enberg Subject: Re: [PATCH v5 05/18] slab/slub: struct memcg_params References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-6-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2012 09:25 PM, JoonSoo Kim wrote: > Hi, Glauber. > > 2012/10/19 Glauber Costa : >> For the kmem slab controller, we need to record some extra >> information in the kmem_cache structure. >> >> Signed-off-by: Glauber Costa >> Signed-off-by: Suleiman Souhlal >> CC: Christoph Lameter >> CC: Pekka Enberg >> CC: Michal Hocko >> CC: Kamezawa Hiroyuki >> CC: Johannes Weiner >> CC: Tejun Heo >> --- >> include/linux/slab.h | 25 +++++++++++++++++++++++++ >> include/linux/slab_def.h | 3 +++ >> include/linux/slub_def.h | 3 +++ >> mm/slab.h | 13 +++++++++++++ >> 4 files changed, 44 insertions(+) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index 0dd2dfa..e4ea48a 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -177,6 +177,31 @@ unsigned int kmem_cache_size(struct kmem_cache *); >> #define ARCH_SLAB_MINALIGN __alignof__(unsigned long long) >> #endif >> >> +#include > > Why workqueue.h is includede at this time? > It may be future use, so is it better to add it later? > Adding it at proper time makes git blame works better. > It is for later, I missed this. Thanks for spotting. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v5 05/18] slab/slub: struct memcg_params Date: Wed, 24 Oct 2012 12:42:31 +0400 Message-ID: <5087A9F7.7070804@parallels.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-6-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: JoonSoo Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg , devel@openvz.org, Suleiman Souhlal , Pekka Enberg On 10/23/2012 09:25 PM, JoonSoo Kim wrote: > Hi, Glauber. > > 2012/10/19 Glauber Costa : >> For the kmem slab controller, we need to record some extra >> information in the kmem_cache structure. >> >> Signed-off-by: Glauber Costa >> Signed-off-by: Suleiman Souhlal >> CC: Christoph Lameter >> CC: Pekka Enberg >> CC: Michal Hocko >> CC: Kamezawa Hiroyuki >> CC: Johannes Weiner >> CC: Tejun Heo >> --- >> include/linux/slab.h | 25 +++++++++++++++++++++++++ >> include/linux/slab_def.h | 3 +++ >> include/linux/slub_def.h | 3 +++ >> mm/slab.h | 13 +++++++++++++ >> 4 files changed, 44 insertions(+) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index 0dd2dfa..e4ea48a 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -177,6 +177,31 @@ unsigned int kmem_cache_size(struct kmem_cache *); >> #define ARCH_SLAB_MINALIGN __alignof__(unsigned long long) >> #endif >> >> +#include > > Why workqueue.h is includede at this time? > It may be future use, so is it better to add it later? > Adding it at proper time makes git blame works better. > It is for later, I missed this. Thanks for spotting. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org