From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966147Ab2JZTT3 (ORCPT ); Fri, 26 Oct 2012 15:19:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47087 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966098Ab2JZTT1 (ORCPT ); Fri, 26 Oct 2012 15:19:27 -0400 Message-ID: <508AE2CD.1010302@redhat.com> Date: Fri, 26 Oct 2012 15:21:49 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Andi Kleen , Michel Lespinasse , Peter Zijlstra , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] x86/mm: only do a local TLB flush in ptep_set_access_flags() References: <20121025121617.617683848@chello.nl> <20121025124832.840241082@chello.nl> <5089F5B5.1050206@redhat.com> <508A0A0D.4090001@redhat.com> <508A8D31.9000106@redhat.com> <20121026132601.GC9886@gmail.com> <20121026144419.7e666023@dull> <508AE1A3.6030607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2012 03:18 PM, Linus Torvalds wrote: > On Fri, Oct 26, 2012 at 12:16 PM, Rik van Riel wrote: >> >> I can change the text of the changelog, however it looks >> like do_wp_page does actually use ptep_set_access_flags >> to set the write bit in the pte... >> >> I guess both need to be reflected in the changelog text >> somehow? > > Yeah, and by now, after all this discussion, I suspect it should be > committed with a comment too. Commit messages are good and all, but > unless chasing a particular bug they introduced, we shouldn't expect > people to read them for background information. Will do :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id 6A3586B0075 for ; Fri, 26 Oct 2012 15:19:20 -0400 (EDT) Message-ID: <508AE2CD.1010302@redhat.com> Date: Fri, 26 Oct 2012 15:21:49 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 1/3] x86/mm: only do a local TLB flush in ptep_set_access_flags() References: <20121025121617.617683848@chello.nl> <20121025124832.840241082@chello.nl> <5089F5B5.1050206@redhat.com> <508A0A0D.4090001@redhat.com> <508A8D31.9000106@redhat.com> <20121026132601.GC9886@gmail.com> <20121026144419.7e666023@dull> <508AE1A3.6030607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Ingo Molnar , Andi Kleen , Michel Lespinasse , Peter Zijlstra , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 10/26/2012 03:18 PM, Linus Torvalds wrote: > On Fri, Oct 26, 2012 at 12:16 PM, Rik van Riel wrote: >> >> I can change the text of the changelog, however it looks >> like do_wp_page does actually use ptep_set_access_flags >> to set the write bit in the pte... >> >> I guess both need to be reflected in the changelog text >> somehow? > > Yeah, and by now, after all this discussion, I suspect it should be > committed with a comment too. Commit messages are good and all, but > unless chasing a particular bug they introduced, we shouldn't expect > people to read them for background information. Will do :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org