From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/fs.c: fix fs_set_blk_dev() for manual relocation
Date: Tue, 30 Oct 2012 12:41:02 -0600 [thread overview]
Message-ID: <50901F3E.2020208@wwwdotorg.org> (raw)
In-Reply-To: <1351621763-26635-1-git-send-email-andreas.devel@googlemail.com>
On 10/30/2012 12:29 PM, Andreas Bie?mann wrote:
> Commit 045fa1e1142552799ad3203e9e0bc22a11e866ea introduce an array with
> filesystem accessors. On arches which need manual reloc this is broken cause the
> function pointers still pointing to the privious location, fix it.
We found the same code to copy:-)
> diff --git a/fs/fs.c b/fs/fs.c
> int fs_set_blk_dev(const char *ifname, const char *dev_part_str, int fstype)
> +#ifdef CONFIG_NEEDS_MANUAL_RELOC
> + static int relocated = 0;
checkpatch bitches about the "= 0" there. I assume BSS initialization
isn't also broken when CONFIG_NEEDS_MANUAL_RELOC is enabled?
next prev parent reply other threads:[~2012-10-30 18:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:43 [U-Boot] [PATCH V4 1/3] fs: delete unused Makefile Stephen Warren
2012-10-22 16:43 ` [U-Boot] [PATCH V4 2/3] fs: separate CONFIG_FS_{FAT, EXT4} from CONFIG_CMD_{FAT, EXT*} Stephen Warren
2012-10-22 16:43 ` [U-Boot] [PATCH V4 3/3] fs: add filesystem switch libary, implement ls and fsload commands Stephen Warren
2012-10-30 11:05 ` Andreas Bießmann
2012-10-30 16:47 ` Tom Rini
2012-10-30 18:29 ` [U-Boot] [PATCH] fs/fs.c: fix fs_set_blk_dev() for manual relocation Andreas Bießmann
2012-10-30 18:41 ` Stephen Warren [this message]
2012-10-30 22:19 ` Tom Rini
2012-10-31 9:42 ` Andreas Bießmann
2012-10-30 17:50 ` [U-Boot] [PATCH] fs: handle CONFIG_NEEDS_MANUAL_RELOC Stephen Warren
2012-10-31 9:47 ` Andreas Bießmann
2012-11-04 18:28 ` Tom Rini
2012-10-30 20:23 ` [U-Boot] [PATCH V4 3/3] fs: add filesystem switch libary, implement ls and fsload commands Benoît Thébaudeau
2012-10-30 21:18 ` Stephen Warren
2012-10-30 21:29 ` Tom Rini
2012-10-30 21:59 ` Benoît Thébaudeau
2012-10-30 22:01 ` Stephen Warren
2012-10-31 10:43 ` Andreas Bießmann
2012-10-31 17:03 ` Stephen Warren
2012-10-29 22:55 ` [U-Boot] [PATCH V4 1/3] fs: delete unused Makefile Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50901F3E.2020208@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.