From: Kaige Li <likaige@loongson.cn>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: David Hildenbrand <david@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 2/2] target/arm: Fix compile error.
Date: Fri, 31 Jul 2020 09:26:47 +0800 [thread overview]
Message-ID: <50913cde-f753-f1d3-efb6-8f71f54353d9@loongson.cn> (raw)
In-Reply-To: <CAFEAcA85xA=T389_M5_vjvm=TPirMqxNDt0za65G2NOfaDHdWA@mail.gmail.com>
On 07/31/2020 04:45 AM, Peter Maydell wrote:
> On Thu, 30 Jul 2020 at 12:58, Kaige Li <likaige@loongson.cn> wrote:
>> When I compile qemu with such as:
>>
>> git clone https://git.qemu.org/git/qemu.git
>> cd qemu
>> git submodule init
>> git submodule update --recursive
>> ./configure
>> make
>>
>> There is error log:
>>
>> /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
>> /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> fn(cpu_reg(s, rt), clean_addr, tcg_rs, get_mem_index(s),
>> ^
>> /home/LiKaige/qemu/target/arm/translate-a64.c:3318:22: note: ‘fn’ was declared here
>> AtomicThreeOpFn *fn;
>> ^
>> cc1: all warnings being treated as errors
>>
>> So, add an initiallization value NULL for fn to fix this.
>>
>> Signed-off-by: Kaige Li <likaige@loongson.cn>
> Hi; I've taken this patch (but not patch 1 in the series)
> into target-arm.next, with the commit message cleaned up
> to quote the compiler version.
Hi, did you mean I should commit this patch separately, not in a series
of patches?
and the submission information should be added to the gcc version and
cpu architecture?
Thanks for your patience and suggestion .
Kaige.
> thanks
> -- PMM
next prev parent reply other threads:[~2020-07-31 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 11:57 [PATCH v2 1/2] virtio-mem: Change PRIx32 to PRIXPTR to fix compile error Kaige Li
2020-07-30 11:57 ` [PATCH v2 2/2] target/arm: Fix " Kaige Li
2020-07-30 13:17 ` Philippe Mathieu-Daudé
2020-07-30 20:47 ` Peter Maydell
2020-07-30 20:45 ` Peter Maydell
2020-07-31 1:26 ` Kaige Li [this message]
2020-07-30 12:03 ` [PATCH v2 1/2] virtio-mem: Change PRIx32 to PRIXPTR to fix " David Hildenbrand
2020-07-30 12:57 ` David Hildenbrand
2020-07-30 13:15 ` Philippe Mathieu-Daudé
2020-07-31 3:52 ` Kaige Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50913cde-f753-f1d3-efb6-8f71f54353d9@loongson.cn \
--to=likaige@loongson.cn \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.