All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Tomasz Figa <t.figa@samsung.com>, Mark Brown <broonie@kernel.org>
Cc: Thomas Abraham <ta.omasab@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Thomas Abraham <thomas.ab@samsung.com>,
	Sangsu Park <sangsu4u.park@samsung.com>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Padmavathi Venna <padma.v@samsung.com>
Subject: Re: [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support
Date: Wed, 16 Apr 2014 20:14:27 +0200	[thread overview]
Message-ID: <5094962.iM2Kd6gfjd@wuerfel> (raw)
In-Reply-To: <534E9AA3.10409@samsung.com>

On Wednesday 16 April 2014 16:58:43 Tomasz Figa wrote:

> On 16.04.2014 16:55, Thomas Abraham wrote:
> > On Wed, Apr 16, 2014 at 8:18 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> >> On 16.04.2014 16:31, Arnd Bergmann wrote:
> >>> sparsemem is still not supported in multiplatform, but after I looked
> >>> at it in more detail, I came to the conclusion that there is no
> >>> reason why it couldn't be. It just needs testing so we are confident
> >>> that it doesn't break other platforms, and we need to find good
> >>> platform-independent values for MAX_PHYSMEM_BITS and SECTION_SIZE_BITS
> >>> to put into asm/memory.h, since we can't have them set in mach/memory.h
> >>> for multiplatform.
> >>>
> >>> Looking at my patch again now, I would actually prefer to kill off
> >>> the single-platform support for exynos right away. I don't see
> >>> any reason to keep it now, and it complicates the test matrix.
> >>
> >>
> >> That would be the best option, assuming that it wouldn't introduce feature
> >> regressions. Unfortunately there is still ongoing work on cpufreq driver to
> >> make it multiplatform-aware, so dropping single platform support right now
> >> would introduce at least this one regression.
> >>
> >> Thomas, is there any progress on new version of Exynos cpufreq rework
> >> series?
> >
> > Hi Tomasz,
> >
> > Yes, I am preparing the fourth version of the cpufreq patches and will
> > post it next week. Mostly, the changes will be addressing your review
> > comments.
> 
> OK. Looking forward to it. Thanks for an update on this.
> 

Cool! This is the only major issue I'm aware of, so I think we're good.

If SPARSEMEM support is still relevant to anybody, I'm sure we can
get that to work as well.

There is one small issue with the sound drivers that came up, and I
assume it was just a mistake. If not, some more work on that might
be needed. See patch below.

	Arnd

8<-------
>From 6f3921c3218509114e855a8ea5932aeea5d3ddfd Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 18 Mar 2014 17:04:59 +0100
Subject: [PATCH] ASoC: samsung: don't build pcm and spdif on exynos

In commit d37bdf736d9b "ASoC: samsung: Use ASoC dmaengine code where
possible", Mark Brown changed the EXYNOS ASoC code to no longer
use the private dma interfaces that are standing in the way of
multiplatform enablement.

However, in 313367e7bfa "ASoC: Samsung: Update Kconfig for I2S,SPDIF
and PCM audio", two new users of that interface appeared, since it
is now possible to enable SND_SOC_SAMSUNG_SMDK_SPDIF and
SND_SOC_SMDK_WM8994_PCM on all Samsung SoCs including EXYNOS.

This patch does a partial revert of 313367e7bfa by allowing these
drivers on all samsung platforms except EXYNOS, so we can proceed
with the multiplatform patches.

If support for these drivers is actually needed on EXYNOS machines,
the drivers should first be moved over to use the dmaengine code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Sangsu Park <sangsu4u.park@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: Padmavathi Venna <padma.v@samsung.com>
Cc: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 7b610a8..efc01e0 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -167,7 +167,7 @@ config SND_SOC_GONI_AQUILA_WM8994
 
 config SND_SOC_SAMSUNG_SMDK_SPDIF
 	tristate "SoC S/PDIF Audio support for SMDK"
-	depends on SND_SOC_SAMSUNG
+	depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS
 	select SND_SAMSUNG_SPDIF
 	help
 	  Say Y if you want to add support for SoC S/PDIF audio on the SMDK.
@@ -183,7 +183,7 @@ config SND_SOC_SMDK_WM8580_PCM
 
 config SND_SOC_SMDK_WM8994_PCM
 	tristate "SoC PCM Audio support for WM8994 on SMDK"
-	depends on SND_SOC_SAMSUNG
+	depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS
 	depends on I2C=y
 	select MFD_WM8994
 	select SND_SOC_WM8994

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support
Date: Wed, 16 Apr 2014 20:14:27 +0200	[thread overview]
Message-ID: <5094962.iM2Kd6gfjd@wuerfel> (raw)
In-Reply-To: <534E9AA3.10409@samsung.com>

On Wednesday 16 April 2014 16:58:43 Tomasz Figa wrote:

> On 16.04.2014 16:55, Thomas Abraham wrote:
> > On Wed, Apr 16, 2014 at 8:18 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> >> On 16.04.2014 16:31, Arnd Bergmann wrote:
> >>> sparsemem is still not supported in multiplatform, but after I looked
> >>> at it in more detail, I came to the conclusion that there is no
> >>> reason why it couldn't be. It just needs testing so we are confident
> >>> that it doesn't break other platforms, and we need to find good
> >>> platform-independent values for MAX_PHYSMEM_BITS and SECTION_SIZE_BITS
> >>> to put into asm/memory.h, since we can't have them set in mach/memory.h
> >>> for multiplatform.
> >>>
> >>> Looking at my patch again now, I would actually prefer to kill off
> >>> the single-platform support for exynos right away. I don't see
> >>> any reason to keep it now, and it complicates the test matrix.
> >>
> >>
> >> That would be the best option, assuming that it wouldn't introduce feature
> >> regressions. Unfortunately there is still ongoing work on cpufreq driver to
> >> make it multiplatform-aware, so dropping single platform support right now
> >> would introduce at least this one regression.
> >>
> >> Thomas, is there any progress on new version of Exynos cpufreq rework
> >> series?
> >
> > Hi Tomasz,
> >
> > Yes, I am preparing the fourth version of the cpufreq patches and will
> > post it next week. Mostly, the changes will be addressing your review
> > comments.
> 
> OK. Looking forward to it. Thanks for an update on this.
> 

Cool! This is the only major issue I'm aware of, so I think we're good.

If SPARSEMEM support is still relevant to anybody, I'm sure we can
get that to work as well.

There is one small issue with the sound drivers that came up, and I
assume it was just a mistake. If not, some more work on that might
be needed. See patch below.

	Arnd

8<-------
>From 6f3921c3218509114e855a8ea5932aeea5d3ddfd Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 18 Mar 2014 17:04:59 +0100
Subject: [PATCH] ASoC: samsung: don't build pcm and spdif on exynos

In commit d37bdf736d9b "ASoC: samsung: Use ASoC dmaengine code where
possible", Mark Brown changed the EXYNOS ASoC code to no longer
use the private dma interfaces that are standing in the way of
multiplatform enablement.

However, in 313367e7bfa "ASoC: Samsung: Update Kconfig for I2S,SPDIF
and PCM audio", two new users of that interface appeared, since it
is now possible to enable SND_SOC_SAMSUNG_SMDK_SPDIF and
SND_SOC_SMDK_WM8994_PCM on all Samsung SoCs including EXYNOS.

This patch does a partial revert of 313367e7bfa by allowing these
drivers on all samsung platforms except EXYNOS, so we can proceed
with the multiplatform patches.

If support for these drivers is actually needed on EXYNOS machines,
the drivers should first be moved over to use the dmaengine code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Sangsu Park <sangsu4u.park@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: Padmavathi Venna <padma.v@samsung.com>
Cc: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 7b610a8..efc01e0 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -167,7 +167,7 @@ config SND_SOC_GONI_AQUILA_WM8994
 
 config SND_SOC_SAMSUNG_SMDK_SPDIF
 	tristate "SoC S/PDIF Audio support for SMDK"
-	depends on SND_SOC_SAMSUNG
+	depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS
 	select SND_SAMSUNG_SPDIF
 	help
 	  Say Y if you want to add support for SoC S/PDIF audio on the SMDK.
@@ -183,7 +183,7 @@ config SND_SOC_SMDK_WM8580_PCM
 
 config SND_SOC_SMDK_WM8994_PCM
 	tristate "SoC PCM Audio support for WM8994 on SMDK"
-	depends on SND_SOC_SAMSUNG
+	depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS
 	depends on I2C=y
 	select MFD_WM8994
 	select SND_SOC_WM8994

  reply	other threads:[~2014-04-16 18:15 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  9:28 [PATCH v2 0/6] Further cleanup and enable multiplat build Sachin Kamat
2014-04-15  9:28 ` Sachin Kamat
2014-04-15  9:28 ` [PATCH 1/6] ARM: EXYNOS: Remove duplicate lines in Makefile Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-15  9:28 ` [PATCH 2/6] ARM: EXYNOS: Remove exynos_subsys registration Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-15  9:28 ` [PATCH 3/6] ARM: EXYNOS: Migrate Exynos specific macros from plat to mach Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-15  9:28 ` [PATCH 4/6] ARM: EXYNOS: Remove unnecessary inclusion of cpu.h Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-15  9:28 ` [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-16 13:51   ` Tomasz Figa
2014-04-16 13:51     ` Tomasz Figa
2014-04-16 14:31     ` Arnd Bergmann
2014-04-16 14:31       ` Arnd Bergmann
2014-04-16 14:48       ` Tomasz Figa
2014-04-16 14:48         ` Tomasz Figa
2014-04-16 14:55         ` Thomas Abraham
2014-04-16 14:55           ` Thomas Abraham
2014-04-16 14:58           ` Tomasz Figa
2014-04-16 14:58             ` Tomasz Figa
2014-04-16 18:14             ` Arnd Bergmann [this message]
2014-04-16 18:14               ` Arnd Bergmann
2014-04-16 20:50               ` Mark Brown
2014-04-16 20:50                 ` Mark Brown
2014-04-16 21:00                 ` Arnd Bergmann
2014-04-16 21:00                   ` Arnd Bergmann
2014-04-22  3:06   ` Olof Johansson
2014-04-22  3:06     ` Olof Johansson
2014-04-22 19:56     ` Arnd Bergmann
2014-04-22 19:56       ` Arnd Bergmann
2014-05-13  4:37       ` Kukjin Kim
2014-05-13  4:37         ` Kukjin Kim
2014-05-13  9:15         ` Arnd Bergmann
2014-05-13  9:15           ` Arnd Bergmann
2014-05-13 18:01           ` Olof Johansson
2014-05-13 18:01             ` Olof Johansson
2014-05-14  4:33             ` Kukjin Kim
2014-05-14  4:33               ` Kukjin Kim
2014-04-15  9:28 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable Exynos platform Sachin Kamat
2014-04-15  9:28   ` Sachin Kamat
2014-04-16 13:51 ` [PATCH v2 0/6] Further cleanup and enable multiplat build Tomasz Figa
2014-04-16 13:51   ` Tomasz Figa
2014-05-04 15:35   ` Sachin Kamat
2014-05-04 15:35     ` Sachin Kamat
2014-05-12 22:30     ` Kukjin Kim
2014-05-12 22:30       ` Kukjin Kim
  -- strict thread matches above, loose matches on Subject: below --
2014-04-10  8:24 [PATCH " Sachin Kamat
2014-04-10  8:24 ` [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support Sachin Kamat
2014-04-10  8:24   ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5094962.iM2Kd6gfjd@wuerfel \
    --to=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=padma.v@samsung.com \
    --cc=sachin.kamat@linaro.org \
    --cc=sangsu4u.park@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=ta.omasab@gmail.com \
    --cc=thomas.ab@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.