From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox Date: Mon, 5 Nov 2012 20:23:11 +0530 Message-ID: <5097D2D7.3090204@ti.com> References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-14-git-send-email-vaibhav.bedia@ti.com> <50953E26.40906@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:33298 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932439Ab2KEOxS (ORCPT ); Mon, 5 Nov 2012 09:53:18 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Bedia, Vaibhav" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , "Hilman, Kevin" , "paul@pwsan.com" , "Cousson, Benoit" , "tony@atomide.com" On Sunday 04 November 2012 08:56 PM, Bedia, Vaibhav wrote: > On Sat, Nov 03, 2012 at 21:24:14, Shilimkar, Santosh wrote: >> On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote: >>> Signed-off-by: Vaibhav Bedia >>> --- >>> arch/arm/boot/dts/am33xx.dtsi | 11 +++++++++++ >>> 1 files changed, 11 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >>> index bb31bff..e2cbf24 100644 >>> --- a/arch/arm/boot/dts/am33xx.dtsi >>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>> @@ -210,5 +210,16 @@ >>> interrupt-parent = <&intc>; >>> interrupts = <91>; >>> }; >>> + >>> + ocmcram: ocmcram@40300000 { >>> + compatible = "ti,ocmcram"; >>> + ti,hwmods = "ocmcram"; >>> + ti,no_idle_on_suspend; >>> + }; >> Whats the intention behind adding OCMRAM ? >> Sorry if I missed any comments from the cover letter ? >> > > We need a mechanism to ensure that the clock to OCMC is kept running > during boot and that it doesn't get disabled as part of the suspend > sequence. Since the hwmod data for OCMC is already present and we have > the no_idle_on_suspend flag for hwmod entries we get the desired behavior. > On OMAP the OCMC RAM is always clocked and doesn't need any special clock enable. CM_L3_2_OCMC_RAM_CLKCTRL module mode field is read only. Isn't it same on AMXX ? > This could also have been done via the clock tree but looks like we > want to avoid adding leaf nodes in the clock data, hence the hwmod + > DT approach. > Sure. I was just trying to see why AMXX is different with OMAP here. Regards Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 5 Nov 2012 20:23:11 +0530 Subject: [PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox In-Reply-To: References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-14-git-send-email-vaibhav.bedia@ti.com> <50953E26.40906@ti.com> Message-ID: <5097D2D7.3090204@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sunday 04 November 2012 08:56 PM, Bedia, Vaibhav wrote: > On Sat, Nov 03, 2012 at 21:24:14, Shilimkar, Santosh wrote: >> On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote: >>> Signed-off-by: Vaibhav Bedia >>> --- >>> arch/arm/boot/dts/am33xx.dtsi | 11 +++++++++++ >>> 1 files changed, 11 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >>> index bb31bff..e2cbf24 100644 >>> --- a/arch/arm/boot/dts/am33xx.dtsi >>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>> @@ -210,5 +210,16 @@ >>> interrupt-parent = <&intc>; >>> interrupts = <91>; >>> }; >>> + >>> + ocmcram: ocmcram at 40300000 { >>> + compatible = "ti,ocmcram"; >>> + ti,hwmods = "ocmcram"; >>> + ti,no_idle_on_suspend; >>> + }; >> Whats the intention behind adding OCMRAM ? >> Sorry if I missed any comments from the cover letter ? >> > > We need a mechanism to ensure that the clock to OCMC is kept running > during boot and that it doesn't get disabled as part of the suspend > sequence. Since the hwmod data for OCMC is already present and we have > the no_idle_on_suspend flag for hwmod entries we get the desired behavior. > On OMAP the OCMC RAM is always clocked and doesn't need any special clock enable. CM_L3_2_OCMC_RAM_CLKCTRL module mode field is read only. Isn't it same on AMXX ? > This could also have been done via the clock tree but looks like we > want to avoid adding leaf nodes in the clock data, hence the hwmod + > DT approach. > Sure. I was just trying to see why AMXX is different with OMAP here. Regards Santosh