* [LTP] Fix cpuhotplug testcase cpuhotplug01 and cpuhotplug03
@ 2012-11-12 7:33 jin.li
2012-11-12 7:33 ` [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01 jin.li
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: jin.li @ 2012-11-12 7:33 UTC (permalink / raw)
To: jin.li, gaowanlong, ltp-list
Hi,
Send out fix for cpuhotplug test case cpuhotplug01, cpuhotplug03 and
cpuhotplug05
Regards,
Jin
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01
2012-11-12 7:33 [LTP] Fix cpuhotplug testcase cpuhotplug01 and cpuhotplug03 jin.li
@ 2012-11-12 7:33 ` jin.li
2012-11-14 6:04 ` Wanlong Gao
2012-11-12 7:34 ` [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03 jin.li
2012-11-12 7:34 ` [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05 jin.li
2 siblings, 1 reply; 13+ messages in thread
From: jin.li @ 2012-11-12 7:33 UTC (permalink / raw)
To: jin.li, gaowanlong, ltp-list
From: Jin Li <jin.li@windriver.com>
Fix for case cpuhotplug01:
1. Give all available parameters to function migrate_irq.
2. Add the INFO note for the IRQ whose IRQ affinity is NOT permitted to changed.
3. Remove the variable cpustate and related code in function do_clean. The cpu,
which was off before the test start, has been closed correctly in do_clean.
4. Add test case PASS at the end of the passed case
Signed-off-by: Jin Li <jin.li@windriver.com>
---
.../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 11 +++++------
testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns | 12 ++++++++----
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
index acf7df1..995c21b 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
@@ -81,11 +81,6 @@ do_clean()
offline_cpu $offline_cpu
: $(( CPU_COUNT -= 1 ))
done
- if [ "x${cpustate}" = x1 ]; then
- online_cpu ${CPU_TO_TEST}
- else
- offline_cpu ${CPU_TO_TEST}
- fi
}
@@ -98,7 +93,7 @@ do_offline()
CPU=${1#cpu}
# Migrate some irq's this way first.
IRQS=`get_all_irqs`
- migrate_irq ${CPU} ${IRQS}
+ migrate_irq "${CPU}" "${IRQS}"
offline_cpu ${CPU}
if [ $? -ne 0 ]; then
if [ "$CPU" -ne 0 ]; then
@@ -191,4 +186,8 @@ do
done
+if [ "$RC" -eq 0 ];then
+ tst_resm TPASS "online and offline cpu${CPU} when writing disk"
+fi
+
exit_clean $RC
diff --git a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
index 8a7cc32..6b3c933 100644
--- a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
+++ b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
@@ -1,3 +1,5 @@
+#!/bin/sh
+
# hotplug.fns - Collection of functions for hotplugging
# operations.
@@ -27,7 +29,8 @@ migrate_irq()
IRQS=$2
for irq in ${IRQS}
do
- echo $MASK > /proc/irq/${irq}/smp_affinity
+ echo $MASK > /proc/irq/${irq}/smp_affinity || \
+ tst_resm TINFO "It is NOT permitted to change the IRQ $irq smp_affinity"
done
}
@@ -106,7 +109,8 @@ offline_cpu()
get_all_cpus()
{
[ -d /sys/devices/system/cpu/cpu0 ] || return 1
- ls -dr /sys/devices/system/cpu/cpu[0-9]* || return 2
+ ls -dr /sys/devices/system/cpu/cpu[0-9]* | \
+ sed "s/\/sys\/devices\/system\/cpu\///g" || return 2
}
@@ -183,8 +187,8 @@ cpu_is_valid()
# cpu_is_online(CPU)
#
-# Returns a true value if the given CPU number is currently online,
-# false otherwise. This function requires the system's CPUs have
+# Returns a 0 value if the given CPU number is currently online,
+# 1 otherwise. This function requires the system's CPUs have
# hotplug capabilities.
#
cpu_is_online()
--
1.7.11
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-12 7:33 [LTP] Fix cpuhotplug testcase cpuhotplug01 and cpuhotplug03 jin.li
2012-11-12 7:33 ` [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01 jin.li
@ 2012-11-12 7:34 ` jin.li
2012-11-14 6:29 ` Wanlong Gao
2012-11-14 8:23 ` Wanlong Gao
2012-11-12 7:34 ` [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05 jin.li
2 siblings, 2 replies; 13+ messages in thread
From: jin.li @ 2012-11-12 7:34 UTC (permalink / raw)
To: jin.li, gaowanlong, ltp-list
From: Jin Li <jin.li@windriver.com>
Fix test case cpuhotplug03 as follows:
1. Avoid to check whether the cpu0 is on.
2. Check the cpu before turn it on
Signed-off-by: Jin Li <jin.li@windriver.com>
---
.../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
index ca636d1..516a21f 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
@@ -60,15 +60,22 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
# Turns on all CPUs and saves their states
for i in $( get_all_cpus ); do
- if ! online_cpu $1; then
- : $(( cpu += 1 ))
- eval "on_${cpu}=$i"
- fi
+ if [ "$i" = "cpu0" ]; then
+ continue
+ fi
+ if ! cpu_is_online $i; then
+ if ! online_cpu $i; then
+ tst_resm TFAIL "Could not online cpu $i"
+ exit_clean 1
+ fi
+ : $(( cpu += 1 ))
+ eval "on_${cpu}=$i"
+ fi
: $(( number_of_cpus += 1 ))
done
if ! offline_cpu ${CPU_TO_TEST} ; then
- tst_resm TBAIL "CPU${CPU_TO_TEST} cannot be offlined"
+ tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be offlined"
exit_clean 1
fi
@@ -90,7 +97,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
tst_resm TINFO "Onlining CPU ${CPU_TO_TEST}"
online_cpu ${CPU_TO_TEST}
RC=$?
- if [ $RC -eq 0 ]; then
+ if [ $RC -ne 0 ]; then
tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be onlined"
exit_clean 1
fi
@@ -101,7 +108,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
ps -o psr -o command --no-headers -C do_spin_loop
RC=$?
NUM=`ps -o psr -o command --no-headers -C do_spin_loop | sed -e "s/^ *//" | cut -d' ' -f 1 | grep "^${CPU_TO_TEST}$" | wc -l`
- if [ $RC -eq 0 ]; then
+ if [ $RC -ne 0 ]; then
tst_resm TBROK "No do_spin_loop processes found on any processor"
elif [ $NUM -lt 1 ]; then
tst_resm TFAIL "No do_spin_loop processes found on CPU${CPU_TO_TEST}"
--
1.7.11
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05
2012-11-12 7:33 [LTP] Fix cpuhotplug testcase cpuhotplug01 and cpuhotplug03 jin.li
2012-11-12 7:33 ` [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01 jin.li
2012-11-12 7:34 ` [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03 jin.li
@ 2012-11-12 7:34 ` jin.li
2012-11-14 6:38 ` Wanlong Gao
2012-11-14 8:23 ` Wanlong Gao
2 siblings, 2 replies; 13+ messages in thread
From: jin.li @ 2012-11-12 7:34 UTC (permalink / raw)
To: jin.li, gaowanlong, ltp-list
From: Jin Li <jin.li@windriver.com>
Check whether sar is available befor run test
Signed-off-by: Jin Li <jin.li@windriver.com>
---
testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
index ad57efe..e64b91c 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
@@ -27,6 +27,11 @@ Desc: Does sar behave properly during CPU hotplug events?
EOF
+which sar > /dev/null 2>&1 || {
+ tst_resm TCONF "sar does not exist"
+ exit_clean 1
+}
+
# Verify the specified CPU is available
if ! cpu_is_valid "${CPU_TO_TEST}" ; then
tst_resm TBROK"CPU${CPU_TO_TEST} not found"
--
1.7.11
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01
2012-11-12 7:33 ` [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01 jin.li
@ 2012-11-14 6:04 ` Wanlong Gao
2012-11-14 6:14 ` Li, Jin
0 siblings, 1 reply; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 6:04 UTC (permalink / raw)
To: jin.li; +Cc: ltp-list
On 11/12/2012 03:33 PM, jin.li@windriver.com wrote:
> From: Jin Li <jin.li@windriver.com>
>
> Fix for case cpuhotplug01:
>
> 1. Give all available parameters to function migrate_irq.
> 2. Add the INFO note for the IRQ whose IRQ affinity is NOT permitted to changed.
> 3. Remove the variable cpustate and related code in function do_clean. The cpu,
> which was off before the test start, has been closed correctly in do_clean.
> 4. Add test case PASS at the end of the passed case
>
> Signed-off-by: Jin Li <jin.li@windriver.com>
> ---
> .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 11 +++++------
> testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns | 12 ++++++++----
> 2 files changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> index acf7df1..995c21b 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
> @@ -81,11 +81,6 @@ do_clean()
> offline_cpu $offline_cpu
> : $(( CPU_COUNT -= 1 ))
> done
> - if [ "x${cpustate}" = x1 ]; then
If so, the cpustate variable need be removed?
Thanks,
Wanlong Gao
> - online_cpu ${CPU_TO_TEST}
> - else
> - offline_cpu ${CPU_TO_TEST}
> - fi
> }
>
>
> @@ -98,7 +93,7 @@ do_offline()
> CPU=${1#cpu}
> # Migrate some irq's this way first.
> IRQS=`get_all_irqs`
> - migrate_irq ${CPU} ${IRQS}
> + migrate_irq "${CPU}" "${IRQS}"
> offline_cpu ${CPU}
> if [ $? -ne 0 ]; then
> if [ "$CPU" -ne 0 ]; then
> @@ -191,4 +186,8 @@ do
>
> done
>
> +if [ "$RC" -eq 0 ];then
> + tst_resm TPASS "online and offline cpu${CPU} when writing disk"
> +fi
> +
> exit_clean $RC
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
> index 8a7cc32..6b3c933 100644
> --- a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
> +++ b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
> @@ -1,3 +1,5 @@
> +#!/bin/sh
> +
> # hotplug.fns - Collection of functions for hotplugging
> # operations.
>
> @@ -27,7 +29,8 @@ migrate_irq()
> IRQS=$2
> for irq in ${IRQS}
> do
> - echo $MASK > /proc/irq/${irq}/smp_affinity
> + echo $MASK > /proc/irq/${irq}/smp_affinity || \
> + tst_resm TINFO "It is NOT permitted to change the IRQ $irq smp_affinity"
> done
> }
>
> @@ -106,7 +109,8 @@ offline_cpu()
> get_all_cpus()
> {
> [ -d /sys/devices/system/cpu/cpu0 ] || return 1
> - ls -dr /sys/devices/system/cpu/cpu[0-9]* || return 2
> + ls -dr /sys/devices/system/cpu/cpu[0-9]* | \
> + sed "s/\/sys\/devices\/system\/cpu\///g" || return 2
> }
>
>
> @@ -183,8 +187,8 @@ cpu_is_valid()
>
> # cpu_is_online(CPU)
> #
> -# Returns a true value if the given CPU number is currently online,
> -# false otherwise. This function requires the system's CPUs have
> +# Returns a 0 value if the given CPU number is currently online,
> +# 1 otherwise. This function requires the system's CPUs have
> # hotplug capabilities.
> #
> cpu_is_online()
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01
2012-11-14 6:04 ` Wanlong Gao
@ 2012-11-14 6:14 ` Li, Jin
0 siblings, 0 replies; 13+ messages in thread
From: Li, Jin @ 2012-11-14 6:14 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On 11/14/2012 02:04 PM, Wanlong Gao wrote:
> On 11/12/2012 03:33 PM, jin.li@windriver.com wrote:
>> From: Jin Li<jin.li@windriver.com>
>>
>> Fix for case cpuhotplug01:
>>
>> 1. Give all available parameters to function migrate_irq.
>> 2. Add the INFO note for the IRQ whose IRQ affinity is NOT permitted to changed.
>> 3. Remove the variable cpustate and related code in function do_clean. The cpu,
>> which was off before the test start, has been closed correctly in do_clean.
>> 4. Add test case PASS at the end of the passed case
>>
>> Signed-off-by: Jin Li<jin.li@windriver.com>
>> ---
>> .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 11 +++++------
>> testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns | 12 ++++++++----
>> 2 files changed, 13 insertions(+), 10 deletions(-)
>>
>> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>> index acf7df1..995c21b 100755
>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>> @@ -81,11 +81,6 @@ do_clean()
>> offline_cpu $offline_cpu
>> : $(( CPU_COUNT -= 1 ))
>> done
>> - if [ "x${cpustate}" = x1 ]; then
>
> If so, the cpustate variable need be removed?
Yep.
Thanks for your reminding.
Any other comments about other two patches?
Regards,
Jin
>
>
> Thanks,
> Wanlong Gao
>
>
>> - online_cpu ${CPU_TO_TEST}
>> - else
>> - offline_cpu ${CPU_TO_TEST}
>> - fi
>> }
>>
>>
>> @@ -98,7 +93,7 @@ do_offline()
>> CPU=${1#cpu}
>> # Migrate some irq's this way first.
>> IRQS=`get_all_irqs`
>> - migrate_irq ${CPU} ${IRQS}
>> + migrate_irq "${CPU}" "${IRQS}"
>> offline_cpu ${CPU}
>> if [ $? -ne 0 ]; then
>> if [ "$CPU" -ne 0 ]; then
>> @@ -191,4 +186,8 @@ do
>>
>> done
>>
>> +if [ "$RC" -eq 0 ];then
>> + tst_resm TPASS "online and offline cpu${CPU} when writing disk"
>> +fi
>> +
>> exit_clean $RC
>> diff --git a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
>> index 8a7cc32..6b3c933 100644
>> --- a/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
>> +++ b/testcases/kernel/hotplug/cpu_hotplug/include/hotplug.fns
>> @@ -1,3 +1,5 @@
>> +#!/bin/sh
>> +
>> # hotplug.fns - Collection of functions for hotplugging
>> # operations.
>>
>> @@ -27,7 +29,8 @@ migrate_irq()
>> IRQS=$2
>> for irq in ${IRQS}
>> do
>> - echo $MASK> /proc/irq/${irq}/smp_affinity
>> + echo $MASK> /proc/irq/${irq}/smp_affinity || \
>> + tst_resm TINFO "It is NOT permitted to change the IRQ $irq smp_affinity"
>> done
>> }
>>
>> @@ -106,7 +109,8 @@ offline_cpu()
>> get_all_cpus()
>> {
>> [ -d /sys/devices/system/cpu/cpu0 ] || return 1
>> - ls -dr /sys/devices/system/cpu/cpu[0-9]* || return 2
>> + ls -dr /sys/devices/system/cpu/cpu[0-9]* | \
>> + sed "s/\/sys\/devices\/system\/cpu\///g" || return 2
>> }
>>
>>
>> @@ -183,8 +187,8 @@ cpu_is_valid()
>>
>> # cpu_is_online(CPU)
>> #
>> -# Returns a true value if the given CPU number is currently online,
>> -# false otherwise. This function requires the system's CPUs have
>> +# Returns a 0 value if the given CPU number is currently online,
>> +# 1 otherwise. This function requires the system's CPUs have
>> # hotplug capabilities.
>> #
>> cpu_is_online()
>>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-12 7:34 ` [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03 jin.li
@ 2012-11-14 6:29 ` Wanlong Gao
2012-11-14 7:01 ` Li, Jin
2012-11-14 8:23 ` Wanlong Gao
1 sibling, 1 reply; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 6:29 UTC (permalink / raw)
To: jin.li; +Cc: ltp-list
On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
> From: Jin Li <jin.li@windriver.com>
>
> Fix test case cpuhotplug03 as follows:
> 1. Avoid to check whether the cpu0 is on.
> 2. Check the cpu before turn it on
>
> Signed-off-by: Jin Li <jin.li@windriver.com>
> ---
> .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> index ca636d1..516a21f 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
> @@ -60,15 +60,22 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>
> # Turns on all CPUs and saves their states
> for i in $( get_all_cpus ); do
> - if ! online_cpu $1; then
> - : $(( cpu += 1 ))
> - eval "on_${cpu}=$i"
> - fi
> + if [ "$i" = "cpu0" ]; then
> + continue
> + fi
> + if ! cpu_is_online $i; then
> + if ! online_cpu $i; then
> + tst_resm TFAIL "Could not online cpu $i"
> + exit_clean 1
> + fi
> + : $(( cpu += 1 ))
> + eval "on_${cpu}=$i"
> + fi
> : $(( number_of_cpus += 1 ))
> done
>
> if ! offline_cpu ${CPU_TO_TEST} ; then
> - tst_resm TBAIL "CPU${CPU_TO_TEST} cannot be offlined"
> + tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be offlined"
> exit_clean 1
> fi
>
> @@ -90,7 +97,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
> tst_resm TINFO "Onlining CPU ${CPU_TO_TEST}"
> online_cpu ${CPU_TO_TEST}
> RC=$?
> - if [ $RC -eq 0 ]; then
> + if [ $RC -ne 0 ]; then
> tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be onlined"
I test with your patch and always failed here,
Running tests.......
<<<test_start>>>
tag=cpuhotplug03 stime=1352874488
cmdline="export CPU_TO_TEST=1; $LTPROOT/testcases/bin/cpu_hotplug/functional/cpuhotplug03.sh"
contacts=""
analysis=exit
<<<test_output>>>
incrementing stop
Name: cpuhotplug03
Date: Wed Nov 14 14:28:08 CST 2012
Desc: Do tasks get scheduled to a newly on-lined CPU?
CPU is 1
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 31631 3.0 0.0 134116 1556 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31632 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31634 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31635 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31636 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31637 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31638 2.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31639 1.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
root 31643 0.0 0.0 133488 1304 pts/1 S 14:28 0:00 grep do_spin_loop
cpuhotplug03 0 TINFO : Onlining CPU 1
cpuhotplug03 1 TFAIL : CPU1 cannot be onlined
Wed Nov 14 14:28:08 CST 2012
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=37 cstime=4
<<<test_end>>>
INFO: ltp-pan reported some tests FAIL
LTP Version: 20120903-133-gb631790
###############################################################
Done executing testcases.
LTP Version: 20120903-133-gb631790
###############################################################
Thanks,
Wanlong Gao
> exit_clean 1
> fi
> @@ -101,7 +108,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
> ps -o psr -o command --no-headers -C do_spin_loop
> RC=$?
> NUM=`ps -o psr -o command --no-headers -C do_spin_loop | sed -e "s/^ *//" | cut -d' ' -f 1 | grep "^${CPU_TO_TEST}$" | wc -l`
> - if [ $RC -eq 0 ]; then
> + if [ $RC -ne 0 ]; then
> tst_resm TBROK "No do_spin_loop processes found on any processor"
> elif [ $NUM -lt 1 ]; then
> tst_resm TFAIL "No do_spin_loop processes found on CPU${CPU_TO_TEST}"
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05
2012-11-12 7:34 ` [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05 jin.li
@ 2012-11-14 6:38 ` Wanlong Gao
2012-11-14 8:23 ` Wanlong Gao
1 sibling, 0 replies; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 6:38 UTC (permalink / raw)
To: jin.li; +Cc: ltp-list
On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
> From: Jin Li <jin.li@windriver.com>
>
> Check whether sar is available befor run test
This is OK to me.
Thanks,
Wanlong Gao
>
> Signed-off-by: Jin Li <jin.li@windriver.com>
> ---
> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index ad57efe..e64b91c 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -27,6 +27,11 @@ Desc: Does sar behave properly during CPU hotplug events?
>
> EOF
>
> +which sar > /dev/null 2>&1 || {
> + tst_resm TCONF "sar does not exist"
> + exit_clean 1
> +}
> +
> # Verify the specified CPU is available
> if ! cpu_is_valid "${CPU_TO_TEST}" ; then
> tst_resm TBROK"CPU${CPU_TO_TEST} not found"
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-14 6:29 ` Wanlong Gao
@ 2012-11-14 7:01 ` Li, Jin
2012-11-14 7:17 ` Wanlong Gao
0 siblings, 1 reply; 13+ messages in thread
From: Li, Jin @ 2012-11-14 7:01 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On 11/14/2012 02:29 PM, Wanlong Gao wrote:
> On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
>> From: Jin Li<jin.li@windriver.com>
>>
>> Fix test case cpuhotplug03 as follows:
>> 1. Avoid to check whether the cpu0 is on.
>> 2. Check the cpu before turn it on
>>
>> Signed-off-by: Jin Li<jin.li@windriver.com>
>> ---
>> .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 21 ++++++++++++++-------
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>> index ca636d1..516a21f 100755
>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>> @@ -60,15 +60,22 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>
>> # Turns on all CPUs and saves their states
>> for i in $( get_all_cpus ); do
>> - if ! online_cpu $1; then
>> - : $(( cpu += 1 ))
>> - eval "on_${cpu}=$i"
>> - fi
>> + if [ "$i" = "cpu0" ]; then
>> + continue
>> + fi
>> + if ! cpu_is_online $i; then
>> + if ! online_cpu $i; then
>> + tst_resm TFAIL "Could not online cpu $i"
>> + exit_clean 1
>> + fi
>> + : $(( cpu += 1 ))
>> + eval "on_${cpu}=$i"
>> + fi
>> : $(( number_of_cpus += 1 ))
>> done
>>
>> if ! offline_cpu ${CPU_TO_TEST} ; then
>> - tst_resm TBAIL "CPU${CPU_TO_TEST} cannot be offlined"
>> + tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be offlined"
>> exit_clean 1
>> fi
>>
>> @@ -90,7 +97,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>> tst_resm TINFO "Onlining CPU ${CPU_TO_TEST}"
>> online_cpu ${CPU_TO_TEST}
>> RC=$?
>> - if [ $RC -eq 0 ]; then
>> + if [ $RC -ne 0 ]; then
>> tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be onlined"
Looks strange. It's just what I fixed.
Could you please help to confirm that the 0002-patch is applied correctly?
Thanks,
Jin
>
> I test with your patch and always failed here,
> Running tests.......
> <<<test_start>>>
> tag=cpuhotplug03 stime=1352874488
> cmdline="export CPU_TO_TEST=1; $LTPROOT/testcases/bin/cpu_hotplug/functional/cpuhotplug03.sh"
> contacts=""
> analysis=exit
> <<<test_output>>>
> incrementing stop
> Name: cpuhotplug03
> Date: Wed Nov 14 14:28:08 CST 2012
> Desc: Do tasks get scheduled to a newly on-lined CPU?
>
> CPU is 1
> USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
> root 31631 3.0 0.0 134116 1556 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31632 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31634 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31635 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31636 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31637 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31638 2.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31639 1.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
> root 31643 0.0 0.0 133488 1304 pts/1 S 14:28 0:00 grep do_spin_loop
> cpuhotplug03 0 TINFO : Onlining CPU 1
> cpuhotplug03 1 TFAIL : CPU1 cannot be onlined
> Wed Nov 14 14:28:08 CST 2012
> <<<execution_status>>>
> initiation_status="ok"
> duration=0 termination_type=exited termination_id=1 corefile=no
> cutime=37 cstime=4
> <<<test_end>>>
> INFO: ltp-pan reported some tests FAIL
> LTP Version: 20120903-133-gb631790
>
> ###############################################################
>
> Done executing testcases.
> LTP Version: 20120903-133-gb631790
> ###############################################################
>
>
> Thanks,
> Wanlong Gao
>
>> exit_clean 1
>> fi
>> @@ -101,7 +108,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>> ps -o psr -o command --no-headers -C do_spin_loop
>> RC=$?
>> NUM=`ps -o psr -o command --no-headers -C do_spin_loop | sed -e "s/^ *//" | cut -d' ' -f 1 | grep "^${CPU_TO_TEST}$" | wc -l`
>> - if [ $RC -eq 0 ]; then
>> + if [ $RC -ne 0 ]; then
>> tst_resm TBROK "No do_spin_loop processes found on any processor"
>> elif [ $NUM -lt 1 ]; then
>> tst_resm TFAIL "No do_spin_loop processes found on CPU${CPU_TO_TEST}"
>>
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-14 7:01 ` Li, Jin
@ 2012-11-14 7:17 ` Wanlong Gao
2012-11-14 7:23 ` Li, Jin
0 siblings, 1 reply; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 7:17 UTC (permalink / raw)
To: Li, Jin; +Cc: ltp-list
On 11/14/2012 03:01 PM, Li, Jin wrote:
>
>
> On 11/14/2012 02:29 PM, Wanlong Gao wrote:
>> On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
>>> From: Jin Li<jin.li@windriver.com>
>>>
>>> Fix test case cpuhotplug03 as follows:
>>> 1. Avoid to check whether the cpu0 is on.
>>> 2. Check the cpu before turn it on
>>>
>>> Signed-off-by: Jin Li<jin.li@windriver.com>
>>> ---
>>> .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 21 ++++++++++++++-------
>>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> index ca636d1..516a21f 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>> @@ -60,15 +60,22 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>>
>>> # Turns on all CPUs and saves their states
>>> for i in $( get_all_cpus ); do
>>> - if ! online_cpu $1; then
>>> - : $(( cpu += 1 ))
>>> - eval "on_${cpu}=$i"
>>> - fi
>>> + if [ "$i" = "cpu0" ]; then
>>> + continue
>>> + fi
>>> + if ! cpu_is_online $i; then
>>> + if ! online_cpu $i; then
>>> + tst_resm TFAIL "Could not online cpu $i"
>>> + exit_clean 1
>>> + fi
>>> + : $(( cpu += 1 ))
>>> + eval "on_${cpu}=$i"
>>> + fi
>>> : $(( number_of_cpus += 1 ))
>>> done
>>>
>>> if ! offline_cpu ${CPU_TO_TEST} ; then
>>> - tst_resm TBAIL "CPU${CPU_TO_TEST} cannot be offlined"
>>> + tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be offlined"
>>> exit_clean 1
>>> fi
>>>
>>> @@ -90,7 +97,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>> tst_resm TINFO "Onlining CPU ${CPU_TO_TEST}"
>>> online_cpu ${CPU_TO_TEST}
>>> RC=$?
>>> - if [ $RC -eq 0 ]; then
>>> + if [ $RC -ne 0 ]; then
>>> tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be onlined"
>
> Looks strange. It's just what I fixed.
>
> Could you please help to confirm that the 0002-patch is applied correctly?
I tested again and it passed. Maybe caused by some cache.
So, can you resend your 1/3 patch and I can apply all these three.
Thanks,
Wanlong Gao
>
> Thanks,
>
> Jin
>
>>
>> I test with your patch and always failed here,
>> Running tests.......
>> <<<test_start>>>
>> tag=cpuhotplug03 stime=1352874488
>> cmdline="export CPU_TO_TEST=1; $LTPROOT/testcases/bin/cpu_hotplug/functional/cpuhotplug03.sh"
>> contacts=""
>> analysis=exit
>> <<<test_output>>>
>> incrementing stop
>> Name: cpuhotplug03
>> Date: Wed Nov 14 14:28:08 CST 2012
>> Desc: Do tasks get scheduled to a newly on-lined CPU?
>>
>> CPU is 1
>> USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
>> root 31631 3.0 0.0 134116 1556 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31632 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31634 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31635 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31636 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31637 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31638 2.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31639 1.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>> root 31643 0.0 0.0 133488 1304 pts/1 S 14:28 0:00 grep do_spin_loop
>> cpuhotplug03 0 TINFO : Onlining CPU 1
>> cpuhotplug03 1 TFAIL : CPU1 cannot be onlined
>> Wed Nov 14 14:28:08 CST 2012
>> <<<execution_status>>>
>> initiation_status="ok"
>> duration=0 termination_type=exited termination_id=1 corefile=no
>> cutime=37 cstime=4
>> <<<test_end>>>
>> INFO: ltp-pan reported some tests FAIL
>> LTP Version: 20120903-133-gb631790
>>
>> ###############################################################
>>
>> Done executing testcases.
>> LTP Version: 20120903-133-gb631790
>> ###############################################################
>>
>>
>> Thanks,
>> Wanlong Gao
>>
>>> exit_clean 1
>>> fi
>>> @@ -101,7 +108,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>> ps -o psr -o command --no-headers -C do_spin_loop
>>> RC=$?
>>> NUM=`ps -o psr -o command --no-headers -C do_spin_loop | sed -e "s/^ *//" | cut -d' ' -f 1 | grep "^${CPU_TO_TEST}$" | wc -l`
>>> - if [ $RC -eq 0 ]; then
>>> + if [ $RC -ne 0 ]; then
>>> tst_resm TBROK "No do_spin_loop processes found on any processor"
>>> elif [ $NUM -lt 1 ]; then
>>> tst_resm TFAIL "No do_spin_loop processes found on CPU${CPU_TO_TEST}"
>>>
>>
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-14 7:17 ` Wanlong Gao
@ 2012-11-14 7:23 ` Li, Jin
0 siblings, 0 replies; 13+ messages in thread
From: Li, Jin @ 2012-11-14 7:23 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On 11/14/2012 03:17 PM, Wanlong Gao wrote:
> On 11/14/2012 03:01 PM, Li, Jin wrote:
>>
>>
>> On 11/14/2012 02:29 PM, Wanlong Gao wrote:
>>> On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
>>>> From: Jin Li<jin.li@windriver.com>
>>>>
>>>> Fix test case cpuhotplug03 as follows:
>>>> 1. Avoid to check whether the cpu0 is on.
>>>> 2. Check the cpu before turn it on
>>>>
>>>> Signed-off-by: Jin Li<jin.li@windriver.com>
>>>> ---
>>>> .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 21 ++++++++++++++-------
>>>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>>> index ca636d1..516a21f 100755
>>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>>> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh
>>>> @@ -60,15 +60,22 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>>>
>>>> # Turns on all CPUs and saves their states
>>>> for i in $( get_all_cpus ); do
>>>> - if ! online_cpu $1; then
>>>> - : $(( cpu += 1 ))
>>>> - eval "on_${cpu}=$i"
>>>> - fi
>>>> + if [ "$i" = "cpu0" ]; then
>>>> + continue
>>>> + fi
>>>> + if ! cpu_is_online $i; then
>>>> + if ! online_cpu $i; then
>>>> + tst_resm TFAIL "Could not online cpu $i"
>>>> + exit_clean 1
>>>> + fi
>>>> + : $(( cpu += 1 ))
>>>> + eval "on_${cpu}=$i"
>>>> + fi
>>>> : $(( number_of_cpus += 1 ))
>>>> done
>>>>
>>>> if ! offline_cpu ${CPU_TO_TEST} ; then
>>>> - tst_resm TBAIL "CPU${CPU_TO_TEST} cannot be offlined"
>>>> + tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be offlined"
>>>> exit_clean 1
>>>> fi
>>>>
>>>> @@ -90,7 +97,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>>> tst_resm TINFO "Onlining CPU ${CPU_TO_TEST}"
>>>> online_cpu ${CPU_TO_TEST}
>>>> RC=$?
>>>> - if [ $RC -eq 0 ]; then
>>>> + if [ $RC -ne 0 ]; then
>>>> tst_resm TFAIL "CPU${CPU_TO_TEST} cannot be onlined"
>>
>> Looks strange. It's just what I fixed.
>>
>> Could you please help to confirm that the 0002-patch is applied correctly?
>
> I tested again and it passed. Maybe caused by some cache.
> So, can you resend your 1/3 patch and I can apply all these three.
Get it. V2 will come up soon.
Jin
>
> Thanks,
> Wanlong Gao
>
>>
>> Thanks,
>>
>> Jin
>>
>>>
>>> I test with your patch and always failed here,
>>> Running tests.......
>>> <<<test_start>>>
>>> tag=cpuhotplug03 stime=1352874488
>>> cmdline="export CPU_TO_TEST=1; $LTPROOT/testcases/bin/cpu_hotplug/functional/cpuhotplug03.sh"
>>> contacts=""
>>> analysis=exit
>>> <<<test_output>>>
>>> incrementing stop
>>> Name: cpuhotplug03
>>> Date: Wed Nov 14 14:28:08 CST 2012
>>> Desc: Do tasks get scheduled to a newly on-lined CPU?
>>>
>>> CPU is 1
>>> USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
>>> root 31631 3.0 0.0 134116 1556 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31632 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31634 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31635 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31636 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31637 0.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31638 2.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31639 1.0 0.0 134116 1560 pts/1 R 14:28 0:00 /bin/sh /opt/ltp/testcases/bin/cpu_hotplug/tools/do_spin_loop
>>> root 31643 0.0 0.0 133488 1304 pts/1 S 14:28 0:00 grep do_spin_loop
>>> cpuhotplug03 0 TINFO : Onlining CPU 1
>>> cpuhotplug03 1 TFAIL : CPU1 cannot be onlined
>>> Wed Nov 14 14:28:08 CST 2012
>>> <<<execution_status>>>
>>> initiation_status="ok"
>>> duration=0 termination_type=exited termination_id=1 corefile=no
>>> cutime=37 cstime=4
>>> <<<test_end>>>
>>> INFO: ltp-pan reported some tests FAIL
>>> LTP Version: 20120903-133-gb631790
>>>
>>> ###############################################################
>>>
>>> Done executing testcases.
>>> LTP Version: 20120903-133-gb631790
>>> ###############################################################
>>>
>>>
>>> Thanks,
>>> Wanlong Gao
>>>
>>>> exit_clean 1
>>>> fi
>>>> @@ -101,7 +108,7 @@ until [ $TST_COUNT -gt $TST_TOTAL ]; do
>>>> ps -o psr -o command --no-headers -C do_spin_loop
>>>> RC=$?
>>>> NUM=`ps -o psr -o command --no-headers -C do_spin_loop | sed -e "s/^ *//" | cut -d' ' -f 1 | grep "^${CPU_TO_TEST}$" | wc -l`
>>>> - if [ $RC -eq 0 ]; then
>>>> + if [ $RC -ne 0 ]; then
>>>> tst_resm TBROK "No do_spin_loop processes found on any processor"
>>>> elif [ $NUM -lt 1 ]; then
>>>> tst_resm TFAIL "No do_spin_loop processes found on CPU${CPU_TO_TEST}"
>>>>
>>>
>>
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03
2012-11-12 7:34 ` [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03 jin.li
2012-11-14 6:29 ` Wanlong Gao
@ 2012-11-14 8:23 ` Wanlong Gao
1 sibling, 0 replies; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 8:23 UTC (permalink / raw)
To: jin.li; +Cc: ltp-list
On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
> From: Jin Li <jin.li@windriver.com>
>
> Fix test case cpuhotplug03 as follows:
> 1. Avoid to check whether the cpu0 is on.
> 2. Check the cpu before turn it on
Applied, thank you.
Wanlong Gao
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05
2012-11-12 7:34 ` [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05 jin.li
2012-11-14 6:38 ` Wanlong Gao
@ 2012-11-14 8:23 ` Wanlong Gao
1 sibling, 0 replies; 13+ messages in thread
From: Wanlong Gao @ 2012-11-14 8:23 UTC (permalink / raw)
To: jin.li; +Cc: ltp-list
On 11/12/2012 03:34 PM, jin.li@windriver.com wrote:
> From: Jin Li <jin.li@windriver.com>
>
> Check whether sar is available befor run test
Applied, thank you.
Wanlong Gao
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-11-14 8:24 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-12 7:33 [LTP] Fix cpuhotplug testcase cpuhotplug01 and cpuhotplug03 jin.li
2012-11-12 7:33 ` [LTP] [PATCH 1/3] Fix cpuhotplug test case cpuhotplug01 jin.li
2012-11-14 6:04 ` Wanlong Gao
2012-11-14 6:14 ` Li, Jin
2012-11-12 7:34 ` [LTP] [PATCH 2/3] Fix cpuhotplug test case cpuhotplug03 jin.li
2012-11-14 6:29 ` Wanlong Gao
2012-11-14 7:01 ` Li, Jin
2012-11-14 7:17 ` Wanlong Gao
2012-11-14 7:23 ` Li, Jin
2012-11-14 8:23 ` Wanlong Gao
2012-11-12 7:34 ` [LTP] [PATCH 3/3] Fix cpuhotplug test case cpuhotplug05 jin.li
2012-11-14 6:38 ` Wanlong Gao
2012-11-14 8:23 ` Wanlong Gao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.