From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41148)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TYwkD-00081d-Ta
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 05:32:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TYwkA-0002RV-RS
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 05:32:25 -0500
Received: from greensocs.com ([87.106.252.221]:37884
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TYwkA-0002RR-Kg
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 05:32:22 -0500
Message-ID: <50A4C4AD.9020509@greensocs.com>
Date: Thu, 15 Nov 2012 11:32:13 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <50A258ED.7080807@greensocs.com> <20121113163242.613b3d07@BR9GNB5Z>
	<50A275EC.3030700@greensocs.com> <20121113190912.56fd8665@BR9GNB5Z>
In-Reply-To: <20121113190912.56fd8665@BR9GNB5Z>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Virtio refactoring.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, aliguori@us.ibm.com, Evgeny Voevodin <e.voevodin@samsung.com>, Mark Burton <mark.burton@greensocs.com>, qemu-devel@nongnu.org, agraf@suse.de

Hi,

On 13/11/2012 19:09, Cornelia Huck wrote:
> On Tue, 13 Nov 2012 17:31:40 +0100
> KONRAD Fr=C3=A9d=C3=A9ric <fred.konrad@greensocs.com> wrote:
>>
>> We'd go from
>>
>> system bus
>> -> virtio transport bridge dev (virtio-xxx-bridge)
>>      -> virtio transport bus (virtio-xxx-bus)
>>         -> virtio transport dev (virtio-<type>-xxx)
>>
>> to
>>
>> system bus
>> -> virtio transport bridge dev (virtio-bridge-xxx)
>>      -> virtio bus (virtio-bus-xxx)
>>         -> virtio dev (virtio-<type>-xxx)
>>
>> ?
>> I'm not sure of what you mean,.. do you mean for s390 ?
>>
>> for the moment we have e.g : virtio-blk-pci ( in virtio-pci.c )
>>
>> and we want virtio-pci -> virtio-bus -> virtio-blk.
>>
>> ( or virtio-mmio -> virtio-bus -> virtio-blk. for pci-less system. )
> I meant the structure you see in 'info qtree'. We might be talking
> about the same thing :)
For the qtree structure we have eg for virtio block :

bus: main-system-bus
   type System
   dev: pcihost, id ""
     bus: pci.0
       type PCI
       dev: virtio-blk-pci, id ""
         ...

And it would become :

bus: main-system-bus
   type System
   dev: pcihost, id ""
     bus: pci.0
       type PCI
       dev: virtio-pci, id ""
         bus: virtio.0
           type VIRTIO
           dev: virtio-blk, id ""
             ...

>
>>>> Is it the right approach ? Do I miss something ?
>>> What of the alias handling? Can this be killed once everything has be=
en
>>> converted?
>> Which alias ?
> The alias stuff in hw/qdev-monitor.c that lets you specify either
> virtio-<type>-<transport> or virtio-<type>.
>
So it would break the alias, we must find a solution for that.

Fred