From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZGXm-00071f-Bx for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:40:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZGXj-0003mM-7X for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:40:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZGXi-0003mD-Sc for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:40:51 -0500 Message-ID: <50A5EDFD.7080904@redhat.com> Date: Fri, 16 Nov 2012 08:40:45 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1352992746-8767-1-git-send-email-stefanha@redhat.com> <1352992746-8767-8-git-send-email-stefanha@redhat.com> <87d2zey3p8.fsf@codemonkey.ws> In-Reply-To: <87d2zey3p8.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Khoa Huynh , Stefan Hajnoczi , Asias He Il 15/11/2012 22:08, Anthony Liguori ha scritto: > Stefan Hajnoczi writes: > >> The virtio-blk-data-plane feature is easy to integrate into >> hw/virtio-blk.c. The data plane can be started and stopped similar to >> vhost-net. >> >> Users can take advantage of the virtio-blk-data-plane feature using the >> new -device virtio-blk-pci,x-data-plane=on property. > > I don't think this should be a property of virtio-blk-pci but rather a > separate device. Since this is all temporary and we want it to become the default (perhaps keeping the old code for ioeventfd=false only), I don't think it really matters. Paolo