From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qAJ3Pto8209943 for ; Sun, 18 Nov 2012 21:25:56 -0600 Received: from fgwmail5.fujitsu.co.jp (fgwmail5.fujitsu.co.jp [192.51.44.35]) by cuda.sgi.com with ESMTP id 2ObZKlRWqrViNme1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 18 Nov 2012 19:28:03 -0800 (PST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 29DE93EE0BC for ; Mon, 19 Nov 2012 12:28:01 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0DC2D45DEB7 for ; Mon, 19 Nov 2012 12:28:01 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id EB87045DEBA for ; Mon, 19 Nov 2012 12:28:00 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id C668C1DB803F for ; Mon, 19 Nov 2012 12:28:00 +0900 (JST) Received: from g01jpexchkw32.g01.fujitsu.local (g01jpexchkw32.g01.fujitsu.local [10.0.193.115]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 85A661DB803B for ; Mon, 19 Nov 2012 12:28:00 +0900 (JST) Message-ID: <50A9A6FE.1080106@jp.fujitsu.com> Date: Mon, 19 Nov 2012 12:26:54 +0900 From: sat MIME-Version: 1.0 Subject: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices References: <4C0EA21B.8020703@sandeen.net> <508ABE75.4030703@sgi.com> In-Reply-To: <508ABE75.4030703@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Rich Johnston Cc: Eric Sandeen , xfs mailing list Hi Rich, Eric (2012/10/27 1:46), Rich Johnston wrote: > On 06/08/2010 03:03 PM, Eric Sandeen wrote: >> If you try running xfstests on lvm volumes which are symlinks, >> it'll fail to run several tests because our _require_scratch >> framework ultimately uses lstat not stat, and does not think >> the lvm device (which is usually a symlink to a dm-X device) >> is a block device. Sigh. >> >> Last try at this - just resolve any symlinked devicenames >> into their realpath(3) in common.config. >> >> This actually seems to work. >> >> Signed-off-by: Eric Sandeen >> >> --- >> >> >> diff --git a/common.config b/common.config >> index 926846b..e5b2483 100644 >> --- a/common.config >> +++ b/common.config > > Looks good > > Reviewed-by: Rich Johnston > > Eric, > > This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f. From: Satoru Takeuchi Commit d5ea873f is not the same as the the following original Eric's patch. http://oss.sgi.com/archives/xfs/2010-06/msg00080.html It does not modify src/Makefile and realpath is never compiled. In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0 if $TEST_DEV or $SCRATCH_DEV are not defined. Cc: Eric Sandeen Cc: Rich Johnston Signed-off-by: Satoru Takeuchi --- common.config | 4 ++-- src/Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common.config b/common.config index 585b150..3240ee9 100644 --- a/common.config +++ b/common.config @@ -221,11 +221,11 @@ else fi # Scripts just don't deal well with symlinked devices -if [ -L $TEST_DEV ]; then +if [ -L "$TEST_DEV" ]; then TEST_DEV=`src/realpath $TEST_DEV` fi -if [ -L $SCRATCH_DEV ]; then +if [ -L "$SCRATCH_DEV" ]; then SCRATCH_DEV=`src/realpath $SCRATCH_DEV` fi diff --git a/src/Makefile b/src/Makefile index f7362a2..9f7281d 100644 --- a/src/Makefile +++ b/src/Makefile @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \ devzero feature alloc fault fstest t_access_root \ godown resvtest writemod makeextents itrash rename \ multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \ - t_mmap_writev + t_mmap_writev realpath LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \ -- 1.7.7.6 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs