From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 04 Dec 2012 09:23:32 +0100 Subject: [U-Boot] [PATCH V4 08/11] imximage: enable word writes for version2 header In-Reply-To: <50B676C2.6070904@boundarydevices.com> References: <1349315254-21151-9-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-1-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-9-git-send-email-troy.kisky@boundarydevices.com> <20121128093920.381B720104E@gemini.denx.de> <50B676C2.6070904@boundarydevices.com> Message-ID: <50BDB304.4020802@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/11/2012 21:40, Troy Kisky wrote: > On 11/28/2012 2:39 AM, Wolfgang Denk wrote: >> Dear Troy Kisky, >> >> In message >> <1354066303-29762-9-git-send-email-troy.kisky@boundarydevices.com> you >> wrote: >>> Before, only 1 write_dcd_command table was built. >>> Now, a new table is built when the size changes. >> I cannot see how the Subject: and the actual commit message (and code) >> are related. >> >> Best regards, >> >> Wolfgang Denk >> > How about this for the commit message > > Before, only 1 write_dcd_command table was built. > Now, a new table is built when the size changes. > > i.e. before this patch, the sequence > DATA 4 0x83FD9014 0x00000000 > DATA 2 0x83FC8000 0x00fe > > was only valid for Version 1 headers, now it is valid > for Version 2 headers as well. Much better ! Maybe you can also change the title of the patch, telling that you are fixing a bug (the fact that first parameter was not correctly interpreted for V2 *is* a bug). And the example explains very well the issue. > > Parameters were changed for set_dcd_val_t to accomplish > this. So, set_dcd_val_v1 for version 1 was also slightly modified. > But no new functionality was added for version 1. > > No current config files use this functionality, but this patch > removes more lines than it adds. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================