All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Michael Pellegrini <mikep86@gmail.com>
Cc: linux-can@vger.kernel.org
Subject: Re: pch_can: Data transmission stops after dropped packet
Date: Tue, 11 Dec 2012 21:21:34 +0100	[thread overview]
Message-ID: <50C795CE.6060804@grandegger.com> (raw)
In-Reply-To: <loom.20121211T153556-802@post.gmane.org>

On 12/11/2012 03:46 PM, Michael Pellegrini wrote:
> Wolfgang Grandegger <wg <at> grandegger.com> writes:
> 
>> To summarize my understanding of your problem(s). As long as there are
>> no I2C transfers, everything works fine, right? The patch below does
>> report some write-readback failures but that's due to reserved read-only
>> bits. I assume t hat you also use my "RFC v2" patches for c_can.
>>
>> Trouble starts with concurrent I2C transfers. Then the protected
>> write-readback test fails, which I regard as abnormal hardware behavior,
>> resulting in message losses and out-of-order reception.
>>
>> Would be interesting to compare the hardware. Michael, could you also
>> show the output of "lspci -vv".
> 
> I applied the patch provided.  On driver load, dmesg reports the following:
> 
> [  379.817717] c_can_pci 0000:02:0c.3: can0: write 0x0 to offset 0x2c failed. 
> got: 0x2000

This is normal because the register returns always that *read-only* bit.
Nothing to worry about. You seem not to observe the serious
write-readback errors Alexander reported.

> "lspci -vv" reports:
> 
> 02:0c.2 Serial bus controller [0c80]: Intel Corporation Platform Controller Hub 
> EG20T I2C Controller
>         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- 
> Stepping- SERR- FastB2B- DisINTx-
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- 
> <MAbort- >SERR- <PERR- INTx-
>         Latency: 0
>         Interrupt: pin C routed to IRQ 7
>         Region 1: Memory at d0144000 (32-bit, non-prefetchable) [size=256]
>         Capabilities: [40] MSI: Enable- Count=1/1 Maskable- 64bit-
>                 Address: 00000000  Data: 0000
>         Capabilities: [50] Power Management version 2
>                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-
> ,D3hot-,D3cold-)
>                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> 
> 02:0c.3 CANBUS: Intel Corporation Platform Controller Hub EG20T Controller Area 
> Network (CAN) Controller
>         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- 
> Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- 
> <MAbort- >SERR- <PERR- INTx-
>         Latency: 0
>         Interrupt: pin C routed to IRQ 42
>         Region 1: Memory at d0143000 (32-bit, non-prefetchable) [size=512]
>         Capabilities: [40] MSI: Enable+ Count=1/1 Maskable- 64bit-
>                 Address: fee0300c  Data: 4179
>         Capabilities: [50] Power Management version 2
>                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-
> ,D3hot-,D3cold-)
>                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>         Kernel driver in use: c_can_pci
>         Kernel modules: c_can_pci
> 
> Based on a quick test, the CAN interface appears functional with this driver.
> However, I am unable to test the I2C interface as I can't get I2C devices to
> appear in /dev right now.
> 
> I apologize for the delay in getting these results back to you.

OK, anyway, thanks for testing.

Wolfgang.


  reply	other threads:[~2012-12-11 20:21 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 15:39 pch_can: Data transmission stops after dropped packet Michael Pellegrini
2012-11-14 21:40 ` Michael Pellegrini
2012-11-15  7:18 ` Oliver Hartkopp
2012-11-15 13:13   ` Wolfgang Grandegger
2012-11-15 16:23     ` Michael Pellegrini
2012-11-15 21:19       ` Wolfgang Grandegger
2012-11-15 21:34         ` Michael Pellegrini
2012-11-15 21:51           ` Wolfgang Grandegger
2012-11-18 22:22           ` Wolfgang Grandegger
2012-11-19 15:10             ` Michael Pellegrini
2012-11-19 15:26               ` Wolfgang Grandegger
2012-11-19 16:20                 ` Michael Pellegrini
2012-11-19 16:31                   ` Wolfgang Grandegger
2012-11-19 17:39                     ` Michael Pellegrini
2012-11-19 19:22                       ` Wolfgang Grandegger
2012-11-19 20:19                         ` Michael Pellegrini
2012-11-19 21:46                           ` Wolfgang Grandegger
2012-11-20 14:25                             ` Michael Pellegrini
2012-11-20 16:12                               ` Wolfgang Grandegger
2012-11-20 19:12                                 ` Michael Pellegrini
2012-11-20 21:05                                   ` Wolfgang Grandegger
2012-11-21 10:24                                     ` Wolfgang Grandegger
     [not found]                                       ` <loom.20121121T160744-278@post.gmane.or  g>
2012-11-21 15:15                                       ` Michael Pellegrini
     [not found]                                       ` <loom.20121121T160744-278@post.gmane.or g>
2012-11-21 15:25                                         ` Michael Pellegrini
2012-11-21 15:32                                           ` Marc Kleine-Budde
2012-11-21 16:11                                             ` Michael Pellegrini
2012-11-21 15:41                                           ` Michael Pellegrini
2012-11-21 15:56                                           ` Wolfgang Grandegger
2012-11-21 16:09                                             ` Michael Pellegrini
2012-11-21 16:41                                               ` Wolfgang Grandegger
2012-11-21 16:58                                                 ` Casper Mogensen
2012-11-21 19:48                                                   ` Wolfgang Grandegger
2012-11-21 17:43                                                 ` Michael Pellegrini
2012-11-21 19:55                                                   ` Wolfgang Grandegger
2012-11-21 21:00                                                     ` Michael Pellegrini
2012-11-23 14:27                                                       ` Michael Pellegrini
2012-11-23 14:45                                                         ` Wolfgang Grandegger
2012-11-23 14:47                                                           ` Wolfgang Grandegger
2012-11-23 15:14                                                             ` Michael Pellegrini
2012-11-23 15:04                                                           ` Michael Pellegrini
2012-11-23 17:00                                                             ` Wolfgang Grandegger
2012-11-23 17:18                                                               ` Wolfgang Grandegger
2012-11-23 17:52                                                                 ` Michael Pellegrini
2012-11-25 16:17                                                                   ` Wolfgang Grandegger
2012-11-26 14:54                                                                     ` Michael Pellegrini
2012-11-26 15:30                                                                       ` Wolfgang Grandegger
2012-11-26 17:30                                                                         ` Michael Pellegrini
2012-11-26 18:13                                                                           ` Wolfgang Grandegger
2012-11-29 12:15                                                                             ` Wolfgang Grandegger
2012-11-29 14:15                                                                               ` Michael Pellegrini
2012-12-06 14:20                                                                                 ` Michael Pellegrini
2012-12-06 14:23                                                                                   ` Marc Kleine-Budde
2012-12-06 14:41                                                                                     ` Wolfgang Grandegger
2012-12-06 14:42                                                                                       ` Marc Kleine-Budde
2012-12-06 14:42                                                                                     ` Michael Pellegrini
2012-12-06 14:49                                                                                   ` Wolfgang Grandegger
2012-12-06 17:05                                                                                     ` Alexander Stein
2012-12-06 22:02                                                                                       ` Wolfgang Grandegger
2012-12-06 23:24                                                                                         ` Marc Kleine-Budde
2012-12-10  8:21                                                                                         ` Alexander Stein
2012-12-11 20:24                                                                                           ` Wolfgang Grandegger
2012-12-13 14:04                                                                                             ` Alexander Stein
2012-12-11 14:46                                                                                         ` Michael Pellegrini
2012-12-11 20:21                                                                                           ` Wolfgang Grandegger [this message]
2012-12-12 13:35                                                                                           ` Alexander Stein
2012-12-06 22:11                                                                                     ` Michael Pellegrini
2012-12-06 23:23                                                                                       ` Michael Pellegrini
2012-11-24  7:16                                                               ` Wolfgang Grandegger
2012-11-26  3:33                                                                 ` Bhupesh SHARMA
2012-11-21 14:52                                     ` Michael Pellegrini
2012-11-21 15:02                                       ` Wolfgang Grandegger
2012-11-15 16:32     ` Casper Mogensen
2012-11-15 21:16       ` Wolfgang Grandegger
2012-11-16 19:39     ` Wolfgang Grandegger
2012-11-15 16:12   ` Michael Pellegrini
2012-11-20 18:59     ` Wolfgang Grandegger
2012-11-15 12:35 ` Steffen Rose
2012-11-15 18:26   ` Michael Pellegrini
2012-11-16  8:24     ` Steffen Rose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C795CE.6060804@grandegger.com \
    --to=wg@grandegger.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mikep86@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.