From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598Ab2LQMG2 (ORCPT ); Mon, 17 Dec 2012 07:06:28 -0500 Received: from exprod5og101.obsmtp.com ([64.18.0.141]:38573 "EHLO exprod5og101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298Ab2LQMG1 (ORCPT ); Mon, 17 Dec 2012 07:06:27 -0500 X-Greylist: delayed 303 seconds by postgrey-1.27 at vger.kernel.org; Mon, 17 Dec 2012 07:06:27 EST Message-ID: <50CF0990.2060606@ge.com> Date: Mon, 17 Dec 2012 12:01:20 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Konstantin Khlebnikov CC: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, Manohar Vanga Subject: Re: [PATCH 05/12] staging: vme_pio2: fix oops on module unloading References: <20121214110229.11019.63713.stgit@zurg> <20121214110244.11019.14075.stgit@zurg> In-Reply-To: <20121214110244.11019.14075.stgit@zurg> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/12 11:02, Konstantin Khlebnikov wrote: > This patch forbids loading vme_pio2 module without specifing "num_bus" parameter. > Otherwise on module unloading pio2_exit() calls vme_unregister_driver() for not > registered pio2_driver. > Acked-by: Martyn Welch > Signed-off-by: Konstantin Khlebnikov > Cc: Martyn Welch > Cc: Manohar Vanga > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > --- > drivers/staging/vme/devices/vme_pio2_core.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c > index 0331178..bf73ba2 100644 > --- a/drivers/staging/vme/devices/vme_pio2_core.c > +++ b/drivers/staging/vme/devices/vme_pio2_core.c > @@ -162,11 +162,9 @@ static struct vme_driver pio2_driver = { > > static int __init pio2_init(void) > { > - int retval = 0; > - > if (bus_num == 0) { > pr_err("No cards, skipping registration\n"); > - goto err_nocard; > + return -ENODEV; > } > > if (bus_num > PIO2_CARDS_MAX) { > @@ -176,15 +174,7 @@ static int __init pio2_init(void) > } > > /* Register the PIO2 driver */ > - retval = vme_register_driver(&pio2_driver, bus_num); > - if (retval != 0) > - goto err_reg; > - > - return retval; > - > -err_reg: > -err_nocard: > - return retval; > + return vme_register_driver(&pio2_driver, bus_num); > } > > static int pio2_match(struct vme_dev *vdev) > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189