From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlVsb-0000a6-4D for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlVsB-0003C9-HG for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:29:01 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:47765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlVsA-0003Bs-Rh for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:28:35 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Dec 2012 12:27:08 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 11A672BB004B for ; Thu, 20 Dec 2012 13:28:21 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBK2H5f84587918 for ; Thu, 20 Dec 2012 13:17:06 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBK2SJqX005421 for ; Thu, 20 Dec 2012 13:28:19 +1100 Message-ID: <50D277A0.6050003@linux.vnet.ibm.com> Date: Thu, 20 Dec 2012 10:27:44 +0800 From: Wenchao Xia MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: Paolo Bonzini , Anthony Liguori , Juan Quintela , qemu-devel@nongnu.org, Dietmar Maurer > > We should also merge functionality of migrations and vm-snapshots and make > some clean-ups of this code. I could do it as another patch. With this > rewrite we could make vm-snapshots asynchronous. > > Hi, Pavel For vm-snapshots asynchronous, I have sent a RFC patch for it at: http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg00800.html and seems dietmar@proxmox.com also have his own solution at: https://git.proxmox.com/?p=pve-qemu-kvm.git;a=blob;f=debian/patches/internal-snapshot-async.patch; So I am reworking on it to include Dietmar's solution, My plan will include three steps: 1) abstract a function for internal/external snapshots(block only). 2) abstract a function for internal/external live vmstate save. 3) assemble above functions at will at above layer. patch for 1) is sent at http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg02393.html I agree that code should be merged as much as possible, just hope my patch wouldn't conflict with yours patch about vmstate save. For vmstate it have a issue about how to limit the file size to be written, that is predict the size to write. We may need a discuss about that.