From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ToBxR-0000KD-2x for qemu-devel@nongnu.org; Thu, 27 Dec 2012 06:49:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ToBxN-0002BN-Tt for qemu-devel@nongnu.org; Thu, 27 Dec 2012 06:49:04 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:63634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ToBxN-0002BI-O2 for qemu-devel@nongnu.org; Thu, 27 Dec 2012 06:49:01 -0500 Received: by mail-wi0-f182.google.com with SMTP id hn14so5299812wib.9 for ; Thu, 27 Dec 2012 03:49:00 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50DC35A8.201@redhat.com> Date: Thu, 27 Dec 2012 12:48:56 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20121206040257.27322.8930.malonedeb@gac.canonical.com> <20121227042700.26057.92281.malone@soybean.canonical.com> In-Reply-To: <20121227042700.26057.92281.malone@soybean.canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1087114 <1087114@bugs.launchpad.net> Cc: qemu-devel@nongnu.org Il 27/12/2012 05:26, Brad Smith ha scritto: > Paolo, > > As you wrote the fallback code which is used when sem_timedwait() is > missing could you please take a look at this when you have some time? I > can test any patches you might come up with. Can you try this: diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c index 7be292e..17f2d7c 100644 --- a/util/qemu-thread-posix.c +++ b/util/qemu-thread-posix.c @@ -213,6 +213,7 @@ int qemu_sem_timedwait(QemuSemaphore *sem, int ms) while (sem->count < 0) { rc = pthread_cond_timedwait(&sem->cond, &sem->lock, &ts); if (rc == ETIMEDOUT) { + ++sem->count; break; } if (rc != 0) { and if it passes, post it? I'll be very sparsely online until Jan 8th. Signed-off-by: Paolo Bonzini Paolo