From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH] fix race condition between libvirtd event
 handling and libxl fd deregister
Date: Mon, 21 Jan 2013 12:37:00 -0700
Message-ID: <50FD98DC.4020203@suse.com>
References: <0451e6041bdd88c90eee.1353395794@linux-bjrd.bjz>	
	<20661.3989.258191.396175@mariner.uk.xensource.com>	
	<1354101923.25834.16.camel@zakaz.uk.xensource.com>	
	<20674.16214.934271.479230@mariner.uk.xensource.com>	
	<1355134766.31710.119.camel@zakaz.uk.xensource.com>	
	<20677.47995.298291.120095@mariner.uk.xensource.com>	
	<20678.5159.946248.90947@mariner.uk.xensource.com>
	<1357904481.20328.42.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1357904481.20328.42.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Bamvor Jian Zhang <bjzhang@suse.com>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell wrote:
> On Mon, 2012-12-10 at 16:56 +0000, Ian Jackson wrote:
>   
>> Ian Jackson writes ("Re: [PATCH] fix race condition between libvirtd event handling and libxl fd deregister"):
>>     
>>> I'm not surprised that the original patch makes Bamvor's symptoms go
>>> away.  Bamvor had one of the possible races (the fd-related one) but
>>> not the other.
>>>       
>> Here (followups to this message, shortly) is v3 of my two-patch series
>> which after conversation with Ian C I think fully fixes the race, and
>> which I have tested now.
>>     
>
> Is this version now tested and ready to be applied?
>   

I have done quite a bit of successful testing with this version and a
libvirt patch series [1] that fixes several races and bugs in the libxl
driver.  So from my perspective, ACK to these patches, assuming my last
comment on patch 2 [2] is addressed.

[1] https://www.redhat.com/archives/libvir-list/2013-January/msg01463.html
[2] http://lists.xen.org/archives/html/xen-devel/2012-12/msg00937.html

Thanks for all the help with resolving these races!

Jim