From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/6] arm: mvebu: Add support for local interrupt Date: Mon, 21 Jan 2013 23:07:10 +0100 Message-ID: <50FDBC0E.1030706@free-electrons.com> References: <1358790842-2986-1-git-send-email-gregory.clement@free-electrons.com> <1358790842-2986-2-git-send-email-gregory.clement@free-electrons.com> <20130121191744.0a04b941@skate> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130121191744.0a04b941@skate> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Thomas Petazzoni Cc: Lior Amsalem , Andrew Lunn , Ike Pan , John Stultz , David Marlin , Yehuda Yitschak , Jani Monoses , Russell King , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Chris Van Hoof , Jon Masters , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nadav Haklai , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maen Suleiman , Shadi Ammouri List-Id: devicetree@vger.kernel.org On 01/21/2013 07:17 PM, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > Just some minor nitpicks below. OK I will take them into account for the V2. Thanks > > On Mon, 21 Jan 2013 18:53:57 +0100, Gregory CLEMENT wrote: > >> + if (hw < ARMADA_370_XP_MAX_PER_CPU_IRQS) { >> + > > Unneeded empty line. > >> + irq_set_percpu_devid(virq); >> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >> + handle_percpu_devid_irq); >> + >> + } else { >> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >> + handle_level_irq); >> + } > > Braces useless since there is only one statement in the else. > >> + set_irq_flags(virq, IRQF_VALID | IRQF_PROBE); > > Incorrect indentation for this line. > > Thomas > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Mon, 21 Jan 2013 23:07:10 +0100 Subject: [PATCH 1/6] arm: mvebu: Add support for local interrupt In-Reply-To: <20130121191744.0a04b941@skate> References: <1358790842-2986-1-git-send-email-gregory.clement@free-electrons.com> <1358790842-2986-2-git-send-email-gregory.clement@free-electrons.com> <20130121191744.0a04b941@skate> Message-ID: <50FDBC0E.1030706@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/21/2013 07:17 PM, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > Just some minor nitpicks below. OK I will take them into account for the V2. Thanks > > On Mon, 21 Jan 2013 18:53:57 +0100, Gregory CLEMENT wrote: > >> + if (hw < ARMADA_370_XP_MAX_PER_CPU_IRQS) { >> + > > Unneeded empty line. > >> + irq_set_percpu_devid(virq); >> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >> + handle_percpu_devid_irq); >> + >> + } else { >> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, >> + handle_level_irq); >> + } > > Braces useless since there is only one statement in the else. > >> + set_irq_flags(virq, IRQF_VALID | IRQF_PROBE); > > Incorrect indentation for this line. > > Thomas > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com