From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754308Ab3AVPWZ (ORCPT ); Tue, 22 Jan 2013 10:22:25 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:47868 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753972Ab3AVPWX (ORCPT ); Tue, 22 Jan 2013 10:22:23 -0500 Message-ID: <50FEAE96.30706@ti.com> Date: Tue, 22 Jan 2013 20:51:58 +0530 From: kishon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Roger Quadros CC: , , , , , , , , , , Subject: Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot References: <1358848694-20145-1-git-send-email-kishon@ti.com> <1358848694-20145-7-git-send-email-kishon@ti.com> <50FE9F5C.2010501@ti.com> <50FEA447.1090701@ti.com> <50FEA696.8000506@ti.com> In-Reply-To: <50FEA696.8000506@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote: > On 01/22/2013 04:37 PM, kishon wrote: >> On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: >>> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: >>>> The OMAP glue has been modified to get PHY by phandle for dt boot. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/usb/musb/omap2430.c | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>>> index 1a8cf6d..e43faeb 100644 >>>> --- a/drivers/usb/musb/omap2430.c >>>> +++ b/drivers/usb/musb/omap2430.c >>>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb) >>>> * up through ULPI. TWL4030-family PMICs include one, >>>> * which needs a driver, drivers aren't always needed. >>>> */ >>>> - musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + if (dev->parent->of_node) >>>> + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, >>>> + "usb_phy", 0); >>>> + else >>>> + musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + >>>> if (IS_ERR_OR_NULL(musb->xceiv)) { >>>> pr_err("HS USB OTG: no transceiver configured\n"); >>>> return -ENODEV; >>> >>> This will not work with PHY driver as a module. You need to use deferred probing mechanism here >>> after you have addressed my comment in patch 2 and also devm_usb_get_phy_by_phandle() >> >> IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver as module, since the kernel will try to probe only till the prompt comes. >> > Oh really? I thought deferred probing takes place whenever a new driver is bound to a device. You might also be right. I'm not so sure. What does "prompt comes" have to do with it? I just meant end of boot process. But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Subject: Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot Date: Tue, 22 Jan 2013 20:51:58 +0530 Message-ID: <50FEAE96.30706@ti.com> References: <1358848694-20145-1-git-send-email-kishon@ti.com> <1358848694-20145-7-git-send-email-kishon@ti.com> <50FE9F5C.2010501@ti.com> <50FEA447.1090701@ti.com> <50FEA696.8000506@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50FEA696.8000506@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Roger Quadros Cc: tony@atomide.com, balbi@ti.com, linux@arm.linux.org.uk, eballetbo@gmail.com, javier@dowhile0.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote: > On 01/22/2013 04:37 PM, kishon wrote: >> On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: >>> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: >>>> The OMAP glue has been modified to get PHY by phandle for dt boot. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/usb/musb/omap2430.c | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>>> index 1a8cf6d..e43faeb 100644 >>>> --- a/drivers/usb/musb/omap2430.c >>>> +++ b/drivers/usb/musb/omap2430.c >>>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb) >>>> * up through ULPI. TWL4030-family PMICs include one, >>>> * which needs a driver, drivers aren't always needed. >>>> */ >>>> - musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + if (dev->parent->of_node) >>>> + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, >>>> + "usb_phy", 0); >>>> + else >>>> + musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + >>>> if (IS_ERR_OR_NULL(musb->xceiv)) { >>>> pr_err("HS USB OTG: no transceiver configured\n"); >>>> return -ENODEV; >>> >>> This will not work with PHY driver as a module. You need to use deferred probing mechanism here >>> after you have addressed my comment in patch 2 and also devm_usb_get_phy_by_phandle() >> >> IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver as module, since the kernel will try to probe only till the prompt comes. >> > Oh really? I thought deferred probing takes place whenever a new driver is bound to a device. You might also be right. I'm not so sure. What does "prompt comes" have to do with it? I just meant end of boot process. But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (kishon) Date: Tue, 22 Jan 2013 20:51:58 +0530 Subject: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot In-Reply-To: <50FEA696.8000506@ti.com> References: <1358848694-20145-1-git-send-email-kishon@ti.com> <1358848694-20145-7-git-send-email-kishon@ti.com> <50FE9F5C.2010501@ti.com> <50FEA447.1090701@ti.com> <50FEA696.8000506@ti.com> Message-ID: <50FEAE96.30706@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote: > On 01/22/2013 04:37 PM, kishon wrote: >> On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: >>> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: >>>> The OMAP glue has been modified to get PHY by phandle for dt boot. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/usb/musb/omap2430.c | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>>> index 1a8cf6d..e43faeb 100644 >>>> --- a/drivers/usb/musb/omap2430.c >>>> +++ b/drivers/usb/musb/omap2430.c >>>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb) >>>> * up through ULPI. TWL4030-family PMICs include one, >>>> * which needs a driver, drivers aren't always needed. >>>> */ >>>> - musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + if (dev->parent->of_node) >>>> + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, >>>> + "usb_phy", 0); >>>> + else >>>> + musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>>> + >>>> if (IS_ERR_OR_NULL(musb->xceiv)) { >>>> pr_err("HS USB OTG: no transceiver configured\n"); >>>> return -ENODEV; >>> >>> This will not work with PHY driver as a module. You need to use deferred probing mechanism here >>> after you have addressed my comment in patch 2 and also devm_usb_get_phy_by_phandle() >> >> IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver as module, since the kernel will try to probe only till the prompt comes. >> > Oh really? I thought deferred probing takes place whenever a new driver is bound to a device. You might also be right. I'm not so sure. What does "prompt comes" have to do with it? I just meant end of boot process. But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Thanks Kishon