From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver Date: Tue, 22 Jan 2013 09:30:03 -0700 Message-ID: <50FEBE8B.60101@wwwdotorg.org> References: <1358591420-7790-1-git-send-email-acourbot@nvidia.com> <1358591420-7790-3-git-send-email-acourbot@nvidia.com> <50FD7EF9.1010205@wwwdotorg.org> <12033649.LY58cllSHv@percival> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <12033649.LY58cllSHv@percival> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Courbot Cc: Thierry Reding , "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mark Zhang , "gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 01/21/2013 08:24 PM, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: >>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- >>> arch/arm/configs/tegra_defconfig | 1 + >>> drivers/video/backlight/Kconfig | 7 ++ >>> drivers/video/backlight/pwm_bl.c | 3 + >>> drivers/video/backlight/pwm_bl_tegra.c | 159 >>> +static struct pwm_backlight_subdriver pwm_backlight_ventana_subdriver = { >>> + .name = "pwm-backlight-ventana", >>> + .init = init_ventana, >>> + .exit = exit_ventana, >>> + .notify = notify_ventana, >>> + .notify_after = notify_after_ventana, >>> +}; >> >> It seems like all of that code should be completely generic. > > Sorry, I don't get your point here - could you elaborate? Nothing there (i.e. in the body of any of those functions) seems remotely specific to Ventana or even Ventana's panel; presumably it would work for any built-in LCD panel? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754256Ab3AVQaL (ORCPT ); Tue, 22 Jan 2013 11:30:11 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:41299 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559Ab3AVQaH (ORCPT ); Tue, 22 Jan 2013 11:30:07 -0500 Message-ID: <50FEBE8B.60101@wwwdotorg.org> Date: Tue, 22 Jan 2013 09:30:03 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Alex Courbot CC: Thierry Reding , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Mark Zhang , "gnurou@gmail.com" Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver References: <1358591420-7790-1-git-send-email-acourbot@nvidia.com> <1358591420-7790-3-git-send-email-acourbot@nvidia.com> <50FD7EF9.1010205@wwwdotorg.org> <12033649.LY58cllSHv@percival> In-Reply-To: <12033649.LY58cllSHv@percival> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2013 08:24 PM, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: >>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- >>> arch/arm/configs/tegra_defconfig | 1 + >>> drivers/video/backlight/Kconfig | 7 ++ >>> drivers/video/backlight/pwm_bl.c | 3 + >>> drivers/video/backlight/pwm_bl_tegra.c | 159 >>> +static struct pwm_backlight_subdriver pwm_backlight_ventana_subdriver = { >>> + .name = "pwm-backlight-ventana", >>> + .init = init_ventana, >>> + .exit = exit_ventana, >>> + .notify = notify_ventana, >>> + .notify_after = notify_after_ventana, >>> +}; >> >> It seems like all of that code should be completely generic. > > Sorry, I don't get your point here - could you elaborate? Nothing there (i.e. in the body of any of those functions) seems remotely specific to Ventana or even Ventana's panel; presumably it would work for any built-in LCD panel? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 22 Jan 2013 16:30:03 +0000 Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver Message-Id: <50FEBE8B.60101@wwwdotorg.org> List-Id: References: <1358591420-7790-1-git-send-email-acourbot@nvidia.com> <1358591420-7790-3-git-send-email-acourbot@nvidia.com> <50FD7EF9.1010205@wwwdotorg.org> <12033649.LY58cllSHv@percival> In-Reply-To: <12033649.LY58cllSHv@percival> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Courbot Cc: Thierry Reding , "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mark Zhang , "gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" On 01/21/2013 08:24 PM, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: >>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- >>> arch/arm/configs/tegra_defconfig | 1 + >>> drivers/video/backlight/Kconfig | 7 ++ >>> drivers/video/backlight/pwm_bl.c | 3 + >>> drivers/video/backlight/pwm_bl_tegra.c | 159 >>> +static struct pwm_backlight_subdriver pwm_backlight_ventana_subdriver = { >>> + .name = "pwm-backlight-ventana", >>> + .init = init_ventana, >>> + .exit = exit_ventana, >>> + .notify = notify_ventana, >>> + .notify_after = notify_after_ventana, >>> +}; >> >> It seems like all of that code should be completely generic. > > Sorry, I don't get your point here - could you elaborate? Nothing there (i.e. in the body of any of those functions) seems remotely specific to Ventana or even Ventana's panel; presumably it would work for any built-in LCD panel?