From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4637C433E0 for ; Thu, 24 Dec 2020 10:36:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E49F22517 for ; Thu, 24 Dec 2020 10:36:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E49F22517 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksNyi-0004rV-5z for qemu-devel@archiver.kernel.org; Thu, 24 Dec 2020 05:36:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksNxg-0003qA-DV; Thu, 24 Dec 2020 05:35:14 -0500 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:60723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksNxb-0002ee-9w; Thu, 24 Dec 2020 05:35:12 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.108.4.89]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 47040769EE12; Thu, 24 Dec 2020 11:35:04 +0100 (CET) Received: from kaod.org (37.59.142.98) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 24 Dec 2020 11:35:03 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-98R002d71fecd8-4f20-4e11-960a-354aa7f7dfb9, 1EADCDB2D537A6DD3E80F364D97246EF8095A17C) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Subject: Re: [PATCH v2 2/2] pnv: Fix reverse dependency on PCI express root ports To: Greg Kurz , References: <160875160729.98237.3219319022197329254.stgit@bahia.lan> <160875161547.98237.12463124171004809427.stgit@bahia.lan> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <50a0a3bc-6e11-43db-48dd-851fb43f052c@kaod.org> Date: Thu, 24 Dec 2020 11:35:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <160875161547.98237.12463124171004809427.stgit@bahia.lan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.98] X-ClientProxiedBy: DAG7EX2.mxp5.local (172.16.2.62) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: face9104-b9fd-4f28-9d6c-6d67539ae78c X-Ovh-Tracer-Id: 7987133943093037987 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrvddtledgudekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepjeekudeuudevleegudeugeekleffveeludejteffiedvledvgfekueefudehheefnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelkeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepghhrohhugheskhgrohgurdhorhhg Received-SPF: pass client-ip=178.32.125.2; envelope-from=clg@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.521, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/23/20 8:26 PM, Greg Kurz wrote: > qemu-system-ppc64 built with --without-default-devices crashes: > > Type 'pnv-phb4-root-port' is missing its parent 'pcie-root-port-base' > Aborted (core dumped) > > Have POWERNV to select PCIE_PORT. This is done through a > new PCI_POWERNV config in hw/pci-host/Kconfig since POWERNV > doesn't have a direct dependency on PCI. For this reason, > PCI_EXPRESS and MSI_NONBROKEN are also moved under > PCI_POWERNV. > > Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/pci-host/Kconfig | 5 +++++ > hw/pci-host/meson.build | 2 +- > hw/ppc/Kconfig | 3 +-- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig > index 036a61877a73..eb03f0489d08 100644 > --- a/hw/pci-host/Kconfig > +++ b/hw/pci-host/Kconfig > @@ -60,3 +60,8 @@ config PCI_BONITO > select PCI > select UNIMP > bool > + > +config PCI_POWERNV > + select PCI_EXPRESS > + select MSI_NONBROKEN > + select PCIE_PORT > diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build > index e6d1b896848c..da9d1a9964a8 100644 > --- a/hw/pci-host/meson.build > +++ b/hw/pci-host/meson.build > @@ -23,7 +23,7 @@ pci_ss.add(when: 'CONFIG_VERSATILE_PCI', if_true: files('versatile.c')) > > softmmu_ss.add_all(when: 'CONFIG_PCI', if_true: pci_ss) > > -specific_ss.add(when: 'CONFIG_POWERNV', if_true: files( > +specific_ss.add(when: 'CONFIG_PCI_POWERNV', if_true: files( > 'pnv_phb3.c', > 'pnv_phb3_msi.c', > 'pnv_phb3_pbcq.c', > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index 064bd6edd83d..501b9868568e 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -29,8 +29,7 @@ config POWERNV > select XICS > select XIVE > select FDT_PPC > - select PCI_EXPRESS > - select MSI_NONBROKEN > + select PCI_POWERNV > > config PPC405 > bool > >