All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michael McConville <mmcco@mykolab.com>, dev@dpdk.org
Subject: Re: [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure
Date: Fri, 1 Dec 2017 16:51:49 -0800	[thread overview]
Message-ID: <50ade726-a5bd-2a94-9f8d-ba3f9658d8a3@intel.com> (raw)
In-Reply-To: <9e13bd6e-e2ad-4ad3-8e02-19f081a997cb@intel.com>

On 12/1/2017 4:50 PM, Ferruh Yigit wrote:
> On 11/30/2017 10:51 PM, Michael McConville wrote:
>> Signed-off-by: Michael McConville <mmcco@mykolab.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> 
> Hi Michael,
> 
> Thanks you for the patch, can you please check the contribution guide [1] for
> expected patch format for next patches.

Ahh, there is checkpatch warning as well, can you make a new version of the
patch with updated patch title and warning fixed?

> 
> [1]
> http://dpdk.org/doc/guides/contributing/patches.html
> 
> <...>
> 

  reply	other threads:[~2017-12-02  0:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  6:51 [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure Michael McConville
2017-12-02  0:50 ` Ferruh Yigit
2017-12-02  0:51   ` Ferruh Yigit [this message]
2018-01-09 16:03     ` Thomas Monjalon
2017-12-02  0:54 ` Ferruh Yigit
2017-12-04  7:32   ` Matej Vido

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ade726-a5bd-2a94-9f8d-ba3f9658d8a3@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=mmcco@mykolab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.